Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267138: Stray suffix when starting gtests via GTestWrapper.java #822

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Oct 24, 2022

Hi all,

Backported since the underlying issue is suspected of causing rare windows gtests errors in JDK17.

This pull request contains a backport of commit b565459f from the openjdk/jdk repository.

The commit being backported was authored by Thomas Stuefe on 25 Jun 2021 and was reviewed by Aleksey Shipilev.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8267138: Stray suffix when starting gtests via GTestWrapper.java

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/822/head:pull/822
$ git checkout pull/822

Update a local copy of the PR:
$ git checkout pull/822
$ git pull https://git.openjdk.org/jdk17u-dev pull/822/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 822

View PR using the GUI difftool:
$ git pr show -t 822

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/822.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b565459f83b749a01d7d873a01bb7dbdf55745de 8267138: Stray suffix when starting gtests via GTestWrapper.java Oct 24, 2022
@openjdk
Copy link

openjdk bot commented Oct 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 24, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8267138: Stray suffix when starting gtests via GTestWrapper.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 24, 2022
@tstuefe tstuefe marked this pull request as ready for review October 24, 2022 15:15
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2022

Webrevs

@tstuefe
Copy link
Member Author

tstuefe commented Oct 25, 2022

Test error on linux x86 unrelated

@tstuefe
Copy link
Member Author

tstuefe commented Oct 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 27, 2022

Going to push as commit f65bf06.
Since your change was applied there have been 14 commits pushed to the master branch:

  • 996c0e9: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free
  • 5de8b9c: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 271d85f: 8294837: unify Windows 2019 version check in os_windows and java_props_md
  • 4df92e1: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • 5ff0ebd: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode
  • bf866a4: 8269571: NMT should print total malloc bytes and invocation count
  • b6f8f49: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
  • cb9289e: 8295429: Update harfbuzz md file
  • 120bf27: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
  • bd2fac8: 8293891: gc/g1/mixedgc/TestOldGenCollectionUsage.java (still) assumes that GCs take 1ms minimum
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/0071802456631b177e9a674bfbba00e5c3bbbf93...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 27, 2022
@openjdk openjdk bot closed this Oct 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 27, 2022
@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@tstuefe Pushed as commit f65bf06.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant