-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8267138: Stray suffix when starting gtests via GTestWrapper.java #822
Conversation
👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@tstuefe This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Test error on linux x86 unrelated |
/integrate |
Going to push as commit f65bf06.
Your commit was automatically rebased without conflicts. |
Hi all,
Backported since the underlying issue is suspected of causing rare windows gtests errors in JDK17.
This pull request contains a backport of commit b565459f from the openjdk/jdk repository.
The commit being backported was authored by Thomas Stuefe on 25 Jun 2021 and was reviewed by Aleksey Shipilev.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/822/head:pull/822
$ git checkout pull/822
Update a local copy of the PR:
$ git checkout pull/822
$ git pull https://git.openjdk.org/jdk17u-dev pull/822/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 822
View PR using the GUI difftool:
$ git pr show -t 822
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/822.diff