Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12 #829

Closed
wants to merge 1 commit into from

Conversation

caojoshua
Copy link
Contributor

@caojoshua caojoshua commented Oct 25, 2022

Not a clean backport because this test in not in ProblemList.txt in JDK17. Clean otherwise. Test passing on my MacOS 12 machine.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/829/head:pull/829
$ git checkout pull/829

Update a local copy of the PR:
$ git checkout pull/829
$ git pull https://git.openjdk.org/jdk17u-dev pull/829/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 829

View PR using the GUI difftool:
$ git pr show -t 829

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/829.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back caojoshua! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 45adc9227a28c8d614c41ac496bbeaa752e5fd7b 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12 Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 25, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@phohensee
Copy link
Member

JBS issue tagged.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@caojoshua This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 25 new commits pushed to the master branch:

  • 9fd15d5: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • 6a45f75: 8280948: Write a regression test for JDK-4659800
  • aa98d09: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
  • 9732004: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading
  • 8194120: 8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java
  • 5977ce5: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
  • ba2f0b4: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath
  • 26351bf: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM
  • b2061e0: 8256811: Delayed/missed jdwp class unloading events
  • 5b6a428: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform
  • ... and 15 more: https://git.openjdk.org/jdk17u-dev/compare/525b9fc903068c9e6518f00c7c6e6df20631f5f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2022
@caojoshua
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 30, 2022
@openjdk
Copy link

openjdk bot commented Oct 30, 2022

@caojoshua
Your change (at version 425ca0d) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 30, 2022

Going to push as commit 5fa5392.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 0698930: 8295288: Some vm_flags tests associate with a wrong BugID
  • 9fd15d5: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • 6a45f75: 8280948: Write a regression test for JDK-4659800
  • aa98d09: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
  • 9732004: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading
  • 8194120: 8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java
  • 5977ce5: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
  • ba2f0b4: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath
  • 26351bf: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM
  • b2061e0: 8256811: Delayed/missed jdwp class unloading events
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/525b9fc903068c9e6518f00c7c6e6df20631f5f4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 30, 2022
@openjdk openjdk bot closed this Oct 30, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 30, 2022
@openjdk
Copy link

openjdk bot commented Oct 30, 2022

@phohensee @caojoshua Pushed as commit 5fa5392.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants