Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4 #832

Closed
wants to merge 13 commits into from

Conversation

adinn
Copy link
Contributor

@adinn adinn commented Oct 25, 2022

Backport of JDK-8291456


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/832/head:pull/832
$ git checkout pull/832

Update a local copy of the PR:
$ git checkout pull/832
$ git pull https://git.openjdk.org/jdk17u-dev pull/832/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 832

View PR using the GUI difftool:
$ git pr show -t 832

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/832.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back adinn! A progress list of the required criteria for merging this PR into pr/831 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2022

Webrevs

@adinn adinn changed the title 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4 Backport c5e0464098f8f7cd9c568c7b1c3a06139453eaab Oct 25, 2022
@openjdk openjdk bot changed the title Backport c5e0464098f8f7cd9c568c7b1c3a06139453eaab 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4 Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

This backport pull request has now been updated with issue from the original commit.

@GoeLin
Copy link
Member

GoeLin commented Oct 27, 2022

@adinn This also has no fix-request comment in the JBS issue. Please add it before pushing.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/831 to master October 28, 2022 12:59
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8291456
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@adinn this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8291456
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

⚠️ @adinn This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Oct 28, 2022
@openjdk openjdk bot added the clean label Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@adinn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed merge-conflict Pull request has merge conflict with target branch labels Oct 28, 2022
@adinn
Copy link
Contributor Author

adinn commented Oct 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

Going to push as commit aa98d09.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2022
@openjdk openjdk bot closed this Oct 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@adinn Pushed as commit aa98d09.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants