Skip to content

8029633: Raw inner class constructor ref should not perform diamond inference #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 25, 2022

I backport this for parity with 17.0.6-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request to be approved

Issues

  • JDK-8029633: Raw inner class constructor ref should not perform diamond inference
  • JDK-8296508: Raw inner class constructor ref should not perform diamond inference (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/835/head:pull/835
$ git checkout pull/835

Update a local copy of the PR:
$ git checkout pull/835
$ git pull https://git.openjdk.org/jdk17u-dev pull/835/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 835

View PR using the GUI difftool:
$ git pr show -t 835

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/835.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6707bfbc153de193b891c1ad3d4d8d0a6ee62307 8029633: Raw inner class constructor ref should not perform diamond inference Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8029633: Raw inner class constructor ref should not perform diamond inference

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

  • 175bd05: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
  • 3486bb2: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
  • 7d17479: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • b5710c4: 8296108: (tz) Update Timezone Data to 2022f
  • f29ade7: 8286872: Refactor add/modify notification icon (TrayIcon)
  • cd4cc5d: 8255439: System Tray icons get corrupted when Windows scaling changes
  • 3d18b23: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails
  • 386f714: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java
  • 574d72f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
  • b7a0a0a: 8273108: RunThese24H crashes with SEGV in markWord::displaced_mark_helper() after JDK-8268276
  • ... and 43 more: https://git.openjdk.org/jdk17u-dev/compare/b6f8f4926bc6ffb443bb6ae4714dec7967d510f4...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 26, 2022

Pre-submit test: tools/jdeps/optionalDependency/OptionalDependencyTest.java
2022-10-25T16:57:46.9187212Z test OptionalDependencyTest.optionalDependenceNotResolved(): failure
2022-10-25T16:57:46.9187753Z java.nio.file.InvalidPathException: Illegal char <:> at index 6: m2.jar:m3.jar
Fixed by JDK-8294840, backport is in work.
Unrelated.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated csr Pull request needs approved CSR before integration labels Nov 8, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Nov 15, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

Going to push as commit 8ce7bb4.
Since your change was applied there have been 54 commits pushed to the master branch:

  • cfedd3f: 8294307: ISO 4217 Amendment 173 Update
  • 175bd05: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
  • 3486bb2: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor
  • 7d17479: 8296480: java/security/cert/pkix/policyChanges/TestPolicy.java is failing
  • b5710c4: 8296108: (tz) Update Timezone Data to 2022f
  • f29ade7: 8286872: Refactor add/modify notification icon (TrayIcon)
  • cd4cc5d: 8255439: System Tray icons get corrupted when Windows scaling changes
  • 3d18b23: 8202836: [macosx] test java/awt/Graphics/TextAAHintsTest.java fails
  • 386f714: 8274029: Remove jtreg tag manual=yesno for java/awt/print/Dialog/DialogOrient.java
  • 574d72f: 8274456: Remove jtreg tag manual=yesno java/awt/print/PrinterJob/PageDialogTest.java
  • ... and 44 more: https://git.openjdk.org/jdk17u-dev/compare/b6f8f4926bc6ffb443bb6ae4714dec7967d510f4...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2022
@openjdk openjdk bot closed this Nov 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@GoeLin Pushed as commit 8ce7bb4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant