Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8281744: x86: Use short jumps in TIG::set_vtos_entry_points #836

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 25, 2022

Clean (and arguably safe) backport to improve cold/interpreter performance.

Additional testing:

  • Linux x86_64 fastdebug tier1
  • Linux x86_64 fastdebug tier2

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8281744: x86: Use short jumps in TIG::set_vtos_entry_points

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/836/head:pull/836
$ git checkout pull/836

Update a local copy of the PR:
$ git checkout pull/836
$ git pull https://git.openjdk.org/jdk17u-dev pull/836/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 836

View PR using the GUI difftool:
$ git pr show -t 836

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/836.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 18704653dcc76b6360b746a6a9c20d614633da0e 8281744: x86: Use short jumps in TIG::set_vtos_entry_points Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8281744: x86: Use short jumps in TIG::set_vtos_entry_points

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • bf866a4: 8269571: NMT should print total malloc bytes and invocation count
  • b6f8f49: 8293701: jdeps InverseDepsAnalyzer runs into NoSuchElementException: No value present
  • cb9289e: 8295429: Update harfbuzz md file
  • 120bf27: 8293657: sun/management/jmxremote/bootstrap/RmiBootstrapTest.java#id1 failed with "SSLHandshakeException: Remote host terminated the handshake"
  • bd2fac8: 8293891: gc/g1/mixedgc/TestOldGenCollectionUsage.java (still) assumes that GCs take 1ms minimum
  • 2f99fbb: 8293489: Accept CAs with BasicConstraints without pathLenConstraint
  • e2b0925: 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown"
  • 491d800: 8293659: Improve UnsatisfiedLinkError error message to include dlopen error details
  • 525b9fc: 8284690: [macos] VoiceOver : Getting java.lang.IllegalArgumentException: Invalid location on Editable JComboBox
  • 0071802: 8286313: [macos] Voice over reads the boolean value as null in the JTable
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/fe4819b5eb25e97b459aded9e1ab93586445b301...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2022

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Nov 8, 2022

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

Going to push as commit 3a5bcf0.
Since your change was applied there have been 43 commits pushed to the master branch:

  • a00bd13: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails
  • a61b74e: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag
  • 18c4c25: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 21c52e3: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false
  • d38a343: 8295554: Move the "sizecalc.h" to the correct location
  • ff14ed4: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • f2a10fd: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation
  • 092be50: 8287740: NSAccessibilityShowMenuAction not working for text editors
  • b37d7df: 8275569: Add linux-aarch64 to test-make profiles
  • eef3c96: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • ... and 33 more: https://git.openjdk.org/jdk17u-dev/compare/fe4819b5eb25e97b459aded9e1ab93586445b301...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 8, 2022
@openjdk openjdk bot closed this Nov 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@shipilev Pushed as commit 3a5bcf0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8281744-tig-vtos branch November 15, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant