Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces #837

Closed

Conversation

rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Oct 25, 2022

This is a clean backport. This failure was reported by users on jdk 17.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/837/head:pull/837
$ git checkout pull/837

Update a local copy of the PR:
$ git checkout pull/837
$ git pull https://git.openjdk.org/jdk17u-dev pull/837/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 837

View PR using the GUI difftool:
$ git pr show -t 837

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/837.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bf39b184ca8aabcc51dc6ea4eee046c69b278710 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Oct 27, 2022

@rwestrel, why are the Pre-submit tests failing?

@rwestrel
Copy link
Contributor Author

rwestrel commented Oct 27, 2022

@rwestrel, why are the Pre-submit tests failing?

@GoeLin I'm not sure but that can't be caused by this change as the test that failed was not even run with shenandoah.

@rwestrel
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 28, 2022

Going to push as commit 5977ce5.
Since your change was applied there have been 11 commits pushed to the master branch:

  • ba2f0b4: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath
  • 26351bf: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM
  • b2061e0: 8256811: Delayed/missed jdwp class unloading events
  • 5b6a428: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform
  • 2e9ef14: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64
  • f65bf06: 8267138: Stray suffix when starting gtests via GTestWrapper.java
  • 996c0e9: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free
  • 5de8b9c: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 271d85f: 8294837: unify Windows 2019 version check in os_windows and java_props_md
  • 4df92e1: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/bf866a449da056cc76825823d24efefedd15db54...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 28, 2022
@openjdk openjdk bot closed this Oct 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 28, 2022
@openjdk
Copy link

openjdk bot commented Oct 28, 2022

@rwestrel Pushed as commit 5977ce5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants