Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295554: Move the "sizecalc.h" to the correct location #839

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Oct 25, 2022

Hi all,
This pull request contains a backport of commit 6673cd85 from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 25 Oct 2022 and was reviewed by Erik Joelsson, Magnus Ihse Bursie, Phil Race, Alexander Zuev and Alexey Ivanov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295554: Move the "sizecalc.h" to the correct location

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/839/head:pull/839
$ git checkout pull/839

Update a local copy of the PR:
$ git checkout pull/839
$ git pull https://git.openjdk.org/jdk17u-dev pull/839/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 839

View PR using the GUI difftool:
$ git pr show -t 839

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/839.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6673cd857722d117b108590ba7f7c02f8622fc3b 8295554: Move the "sizecalc.h" to the correct location Oct 25, 2022
@openjdk
Copy link

openjdk bot commented Oct 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 25, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295554: Move the "sizecalc.h" to the correct location

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 4df92e1: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • 5ff0ebd: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 25, 2022
@mrserb mrserb marked this pull request as ready for review October 26, 2022 08:38
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 26, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Oct 27, 2022

@mrserb, why are the tests failing?

@phohensee
Copy link
Member

Failure is in langtools and appears unrelated. I've seen it before.

@mrserb
Copy link
Member Author

mrserb commented Nov 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 4, 2022

Going to push as commit d38a343.
Since your change was applied there have been 26 commits pushed to the master branch:

  • ff14ed4: 8292695: SIGQUIT and jcmd attaching mechanism does not work with signal chaining library
  • f2a10fd: 8265489: Stress test times out because of long ObjectSynchronizer::monitors_iterate(...) operation
  • 092be50: 8287740: NSAccessibilityShowMenuAction not working for text editors
  • b37d7df: 8275569: Add linux-aarch64 to test-make profiles
  • eef3c96: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary
  • e609398: 8287011: Improve container information
  • d5fedc5: 8244670: convert clhsdb "whatis" command from javascript to java
  • 5fa5392: 8273578: javax/swing/JMenu/4515762/bug4515762.java fails on macOS 12
  • 0698930: 8295288: Some vm_flags tests associate with a wrong BugID
  • 9fd15d5: 8233648: [TESTBUG] DefaultMenuBarTest.java failing on macos
  • ... and 16 more: https://git.openjdk.org/jdk17u-dev/compare/bf866a449da056cc76825823d24efefedd15db54...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 4, 2022
@openjdk openjdk bot closed this Nov 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 4, 2022
@openjdk
Copy link

openjdk bot commented Nov 4, 2022

@mrserb Pushed as commit d38a343.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants