-
Notifications
You must be signed in to change notification settings - Fork 224
8268276: Base64 Decoding optimization for x86 using AVX-512 #840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back asgibbons! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/label add hotspot |
@asgibbons |
Hi Scott, Can you post the diff between this backport and the original JDK-8268276 patch? I'm guessing it's pretty small, but it will be good to see. Thanks!
|
__ vpternlogd(input0, 0xfe, input1, input2, Assembler::AVX_512bit); | ||
|
||
__ vpternlogd(input3, 0xfe, translated0, translated1, Assembler::AVX_512bit); | ||
__ vpternlogd(input0, 0xfe, translated2, translated3, Assembler::AVX_512bit); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line (6039) was changed from
__ vpternlogd(input0, 0xfe, translated1, translated2, Assembler::AVX_512bit);
It was changed to:
__ vpternlogd(input0, 0xfe, translated2, translated3, Assembler::AVX_512bit);
|
__ vpermb(merged0, pack24bits, merged0, Assembler::AVX_512bit); | ||
|
||
__ evmovdqub(Address(dest, dp), k2, merged0, true, Assembler::AVX_512bit); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 6097, 6098, and 6121 were hand-merged from JDK-8273108.
@dwhite-intel Did I answer your question to your satisfaction? I'd appreciate a review if you have time. Thanks! |
So, the original patch applied cleanly, then I included the two bugfixes that were subsequently found (JDK-8273108 and JDK-8269404), one relating to improper illegal character discovery and the other relating to writing past end-of-string. |
This looks good to me. Still need a (R)eviewer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you didn't backport the change to .gitignore. Seems unrelated to the rest of the patch, but harmless enough.
Other than that, lgtm.
Thanks, @phohensee . This is an unneeded artifact of me using VS for editing. I do not believe it affects anything. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it doesn't affect anything, but might be a merge conflict down the line. Let's see what the approvers say. Lgtm.
@asgibbons This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 30 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@asgibbons Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
@asgibbons Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
/contributor add drwhite |
@asgibbons |
@asgibbons Syntax:
User names can only be used for users in the census associated with this repository. For other contributors you need to supply the full name and email address. |
/contributor add sviswanathan |
@asgibbons |
/integrate defer |
@asgibbons Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command. |
/integrate undefer |
@asgibbons Integration of this pull request is no longer deferred and may only be integrated by the author (@asgibbons)using the /integrate pull request command. |
@asgibbons |
/integrate defer |
@asgibbons Integration of this pull request has been deferred and may be completed by any project committer using the /integrate pull request command. |
Trying to do dependent PRs instead of piecemealing. Let me know if I'm doing something wrong. |
This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512.
We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement.
Original patch does not apply cleanly to 17u, because of a bug that was identified in the original commit, but not fixed until the later Base64 Encode acceleration enhancement was complete. The fix is on line 6039 of src/hotspot/cpu/x86/stubGenerator_x86_64.cpp and has been included in this PR. All four "translatedX" registers needed to be checked for illegal characters in the input stream.
Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported.
Testing: x86_64 build, affected tests, tier1, tier2
Thanks,
--Scott
Progress
Issue
Reviewers
Contributors
<drwhite@openjdk.org>
<sviswanathan@openjdk.org>
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/840/head:pull/840
$ git checkout pull/840
Update a local copy of the PR:
$ git checkout pull/840
$ git pull https://git.openjdk.org/jdk17u-dev pull/840/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 840
View PR using the GUI difftool:
$ git pr show -t 840
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/840.diff