Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280948: Write a regression test for JDK-4659800 #846

Closed

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Oct 26, 2022

Backport JDK-8280948 Write a regression test for JDK-4659800

Clean backport, parity with 17.0.5-oracle
Test pass during manual run.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/846/head:pull/846
$ git checkout pull/846

Update a local copy of the PR:
$ git checkout pull/846
$ git pull https://git.openjdk.org/jdk17u-dev pull/846/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 846

View PR using the GUI difftool:
$ git pr show -t 846

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/846.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 66b2c3b66e253ac3d8718c0c6d7c7551dbe04001 8280948: Write a regression test for JDK-4659800 Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280948: Write a regression test for JDK-4659800

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • f65bf06: 8267138: Stray suffix when starting gtests via GTestWrapper.java
  • 996c0e9: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free
  • 5de8b9c: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 271d85f: 8294837: unify Windows 2019 version check in os_windows and java_props_md
  • 4df92e1: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2022
@mlbridge
Copy link

mlbridge bot commented Oct 26, 2022

Webrevs

@Rudometov
Copy link
Member Author

Windows langtools OptionalDependencyTest.java fails (expected, JDK-8295932) and is not related to newly added test/jdk/javax/swing/JButton/4659800/EnterKeyActivatesButton.java

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 27, 2022
@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@Rudometov
Your change (at version 85adb84) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Oct 29, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 29, 2022

Going to push as commit 6a45f75.
Since your change was applied there have been 14 commits pushed to the master branch:

  • aa98d09: 8291456: com/sun/jdi/ClassUnloadEventTest.java failed with: Wrong number of class unload events: expected 10 got 4
  • 9732004: 8292879: com/sun/jdi/ClassUnloadEventTest.java failed due to classes not unloading
  • 8194120: 8292880: Improve debuggee logging for com/sun/jdi/ClassUnloadEventTest.java
  • 5977ce5: 8288302: Shenandoah: SIGSEGV in vm maybe related to jit compiling xerces
  • ba2f0b4: 8291650: Add delay to ClassUnloadEventTest before exiting to give time for JVM to send all events before VMDeath
  • 26351bf: 8290908: misc tests fail: assert(!thread->owns_locks()) failed: must release all locks when leaving VM
  • b2061e0: 8256811: Delayed/missed jdwp class unloading events
  • 5b6a428: 8292899: CustomTzIDCheckDST.java testcase failed on AIX platform
  • 2e9ef14: 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64
  • f65bf06: 8267138: Stray suffix when starting gtests via GTestWrapper.java
  • ... and 4 more: https://git.openjdk.org/jdk17u-dev/compare/5ff0ebd589746908b89f4dc60885f14b30c44a59...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 29, 2022
@openjdk openjdk bot closed this Oct 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 29, 2022
@openjdk
Copy link

openjdk bot commented Oct 29, 2022

@mrserb @Rudometov Pushed as commit 6a45f75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants