Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64 #847

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Oct 26, 2022

JDK-8272123 Problem list 4 jtreg tests which regularly fail on macos-aarch64

Backport not clean, but the fix is trivial.
Low risk, test ProblemList update.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/847/head:pull/847
$ git checkout pull/847

Update a local copy of the PR:
$ git checkout pull/847
$ git pull https://git.openjdk.org/jdk17u-dev pull/847/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 847

View PR using the GUI difftool:
$ git pr show -t 847

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/847.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 26, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0ac2be9b35c56b4b1574cf03fe81111d3f39bedb 8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64 Oct 26, 2022
@openjdk
Copy link

openjdk bot commented Oct 26, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 26, 2022
@Rudometov
Copy link
Member Author

Windows langtools OptionalDependencyTest.java fails (expected, JDK-8295932) and is not related to this change.

@mlbridge
Copy link

mlbridge bot commented Oct 26, 2022

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

java/awt/Frame/MiscUndecorated/RepaintTest.java 8079267,8266244 windows-all,linux-all,macosx-aarch64

is the deleted line in the backport. 8079267 and 8266244 don't exist in the JDK 17 problem list.

Pre-submit test failure appears unrelated, since it occurs in the langtools tests, not the jdk tests.

Lgtm.

@openjdk
Copy link

openjdk bot commented Oct 26, 2022

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8272123: Problem list 4 jtreg tests which regularly fail on macos-aarch64

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • f65bf06: 8267138: Stray suffix when starting gtests via GTestWrapper.java
  • 996c0e9: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free
  • 5de8b9c: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 271d85f: 8294837: unify Windows 2019 version check in os_windows and java_props_md
  • 4df92e1: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • 5ff0ebd: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 26, 2022
@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 27, 2022
@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@Rudometov
Your change (at version 364115f) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 27, 2022

Going to push as commit 2e9ef14.
Since your change was applied there have been 6 commits pushed to the master branch:

  • f65bf06: 8267138: Stray suffix when starting gtests via GTestWrapper.java
  • 996c0e9: 8292778: EncodingSupport_md.c convertUtf8ToPlatformString wrong placing of free
  • 5de8b9c: 8295412: support latest VS2022 MSC_VER in abstract_vm_version.cpp
  • 271d85f: 8294837: unify Windows 2019 version check in os_windows and java_props_md
  • 4df92e1: 8294840: langtools OptionalDependencyTest.java use File.pathSeparator
  • 5ff0ebd: 8277881: Missing SessionID in TLS1.3 resumption in compatibility mode

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 27, 2022
@openjdk openjdk bot closed this Oct 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 27, 2022
@openjdk
Copy link

openjdk bot commented Oct 27, 2022

@phohensee @Rudometov Pushed as commit 2e9ef14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the Backport-8272123 branch January 20, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants