-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8072070: Improve interpreter stack banging #848
Conversation
👋 Welcome back dchuyko! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
@dchuyko This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@dchuyko This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@dchuyko This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Original patch applies almost cleanly. The only difference is in os.cpp where
thread->as_Java_thread()
is used instead ofJavaThread::cast(thread)
because https://bugs.openjdk.org/browse/JDK-8268368 (Adopt cast notation for JavaThread conversions) is not in 17u.Testing: jtreg tier1, tier2 on x86 and aarch64.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/848/head:pull/848
$ git checkout pull/848
Update a local copy of the PR:
$ git checkout pull/848
$ git pull https://git.openjdk.org/jdk17u-dev pull/848/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 848
View PR using the GUI difftool:
$ git pr show -t 848
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/848.diff