Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295714: GHA ::set-output is deprecated and will be removed #852

Closed
wants to merge 1 commit into from

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Nov 1, 2022

This backport fixes warnings generated in GHA summary page by use of deprecated set-output command. According to warning messages command will be removed soon:

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/`

Clean backport, all tests passed (no warnings).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295714: GHA ::set-output is deprecated and will be removed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/852/head:pull/852
$ git checkout pull/852

Update a local copy of the PR:
$ git checkout pull/852
$ git pull https://git.openjdk.org/jdk17u-dev pull/852/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 852

View PR using the GUI difftool:
$ git pr show -t 852

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/852.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2022

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b35922be6de7b848a2982d6a278dbd205fc39e6a 8295714: GHA ::set-output is deprecated and will be removed Nov 1, 2022
@openjdk
Copy link

openjdk bot commented Nov 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 1, 2022

@zzambers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295714: GHA ::set-output is deprecated and will be removed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e609398: 8287011: Improve container information

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2022

Webrevs

@zzambers
Copy link
Contributor Author

zzambers commented Nov 2, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 2, 2022
@openjdk
Copy link

openjdk bot commented Nov 2, 2022

@zzambers
Your change (at version aedc867) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

Going to push as commit 3df72a3.
Since your change was applied there have been 17 commits pushed to the master branch:

  • 7d183e0: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • 703a82a: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 7723bb3: 8286172: Create an automated test for JDK-4516019
  • c29dc16: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • 6196d93: 8283199: Linux os::cpu_microcode_revision() stalls cold startup
  • 3a5bcf0: 8281744: x86: Use short jumps in TIG::set_vtos_entry_points
  • a00bd13: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails
  • a61b74e: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag
  • 18c4c25: 8277970: Test jdk/sun/security/ssl/SSLSessionImpl/NoInvalidateSocketException.java fails with "tag mismatch"
  • 21c52e3: 8290920: sspi_bridge.dll not built if BUILD_CRYPTO is false
  • ... and 7 more: https://git.openjdk.org/jdk17u-dev/compare/d5fedc5b5fdfaa852894b6374873012645576f15...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2022
@openjdk openjdk bot closed this Nov 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@phohensee @zzambers Pushed as commit 3df72a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants