Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278309: [windows] use of uninitialized OSThread::_state #86

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jan 13, 2022

Hi,

This should be backported to jdk17 for parity with Oracle, because it fixes a theoretical crash (probably can't happen). We already fixed this in 11u. Was delayed due to vacations.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8278309: [windows] use of uninitialized OSThread::_state

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/86/head:pull/86
$ git checkout pull/86

Update a local copy of the PR:
$ git checkout pull/86
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/86/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 86

View PR using the GUI difftool:
$ git pr show -t 86

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/86.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 13, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 54993b13078ceb05736bb0e1d7ed7415c390442e 8278309: [windows] use of uninitialized OSThread::_state Jan 13, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8278309: [windows] use of uninitialized OSThread::_state

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 13, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 13, 2022

Webrevs

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Jan 14, 2022

Got approval.

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2022

Going to push as commit 84457e5.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 78e2153: 8274506: TestPids.java and TestPidsLimit.java fail with podman run as root
  • fc92adc: 8276764: Enable deterministic file content ordering for Jar and Jmod
  • 0130fdc: 8273967: gtest os.dll_address_to_function_and_library_name_vm fails on macOS12
  • 4b5b58d: 8273366: [testbug] javax/swing/UIDefaults/6302464/bug6302464.java fails on macOS12
  • 3c279bd: 8277846: Implement fast-path for ASCII-compatible CharsetEncoders on ppc64
  • 061bf8f: 8273526: Extend the OSContainer API pids controller with pids.current
  • f652b44: 8269849: vmTestbase/gc/gctests/PhantomReference/phantom002/TestDescription.java failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • 2e5c400: 8269087: CheckSegmentedCodeCache test fails in an emulated-client VM
  • 30c263c: 8278871: [JVMCI] assert((uint)reason < 2* _trap_hist_limit) failed: oob
  • 2886a4d: 8277447: Hotspot C1 compiler crashes on Kotlin suspend fun with loop

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 14, 2022
@openjdk openjdk bot closed this Jan 14, 2022
@openjdk openjdk bot removed ready rfr labels Jan 14, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 14, 2022

@tstuefe Pushed as commit 84457e5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant