Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8268276: Base64 Decoding optimization for x86 using AVX-512 #860

Closed
wants to merge 1 commit into from

Conversation

asgibbons
Copy link
Contributor

@asgibbons asgibbons commented Nov 8, 2022

This is a backport of JDK-8268276: Base64 Decoding optimization for x86 using AVX-512. Backport is clean.

We have had numerous customer requests for this functionality to be backported due to the ~19x performance improvement.

There will be four additional PRs for which this is a dependency: #861 #862 #863 #864

Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported.

Testing: x86_64 build, affected tests, tier1

Thanks,
--Scott


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8268276: Base64 Decoding optimization for x86 using AVX-512

Contributors

  • Derek White <drwhite@openjdk.org>
  • Sandhya Viswanathan <sviswanathan@openjdk.org>

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/860/head:pull/860
$ git checkout pull/860

Update a local copy of the PR:
$ git checkout pull/860
$ git pull https://git.openjdk.org/jdk17u-dev pull/860/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 860

View PR using the GUI difftool:
$ git pr show -t 860

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/860.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back asgibbons! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c37988d0793b24d98d285530dfda69999a227937 8268276: Base64 Decoding optimization for x86 using AVX-512 Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

This backport pull request has now been updated with issue from the original commit.

@asgibbons
Copy link
Contributor Author

/contributor add drwhite
/contributor add sviswanathan

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@asgibbons This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8268276: Base64 Decoding optimization for x86 using AVX-512

Co-authored-by: Derek White <drwhite@openjdk.org>
Co-authored-by: Sandhya Viswanathan <sviswanathan@openjdk.org>

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • 703a82a: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 7723bb3: 8286172: Create an automated test for JDK-4516019
  • c29dc16: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • 6196d93: 8283199: Linux os::cpu_microcode_revision() stalls cold startup
  • 3a5bcf0: 8281744: x86: Use short jumps in TIG::set_vtos_entry_points
  • a00bd13: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails
  • a61b74e: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@asgibbons
Contributor Derek White <drwhite@openjdk.org> successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 8, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

@asgibbons
Contributor Sandhya Viswanathan <sviswanathan@openjdk.org> successfully added.

@asgibbons
Copy link
Contributor Author

/integrate
Thanks, Goetz.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@asgibbons
Your change (at version e88dea1) is now ready to be sponsored by a Committer.

@dwhite-intel
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

Going to push as commit 07050b0.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 3df72a3: 8295714: GHA ::set-output is deprecated and will be removed
  • 7d183e0: 8296485: BuildEEBasicConstraints.java test fails with SunCertPathBuilderException
  • 703a82a: 8288132: Update test artifacts in QuoVadis CA interop tests
  • 7723bb3: 8286172: Create an automated test for JDK-4516019
  • c29dc16: 8273685: Remove jtreg tag manual=yesno for java/awt/Graphics/LCDTextAndGraphicsState.java & show test instruction
  • 6196d93: 8283199: Linux os::cpu_microcode_revision() stalls cold startup
  • 3a5bcf0: 8281744: x86: Use short jumps in TIG::set_vtos_entry_points
  • a00bd13: 8279941: sun/security/pkcs11/Signature/TestDSAKeyLength.java fails when NSS version detection fails
  • a61b74e: 8272608: java_lang_System::allow_security_manager() doesn't set its initialization flag

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 9, 2022
@openjdk openjdk bot closed this Nov 9, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 9, 2022
@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@dwhite-intel @asgibbons Pushed as commit 07050b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants