-
Notifications
You must be signed in to change notification settings - Fork 232
8274527: Minimal VM build fails after JDK-8273459 #863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back asgibbons! A progress list of the required criteria for merging this PR into |
|
|
|
This backport pull request has now been updated with issue from the original commit. |
|
/integrate |
|
@asgibbons This pull request has not yet been marked as ready for integration. |
|
/sponsor |
|
@dwhite-intel The change author (@asgibbons) must issue an |
|
/integrate |
|
@asgibbons This pull request has not yet been marked as ready for integration. |
|
Opened a clean PR #869 |
|
Closing this because of dependent PR issues. See #861 for details. |
Second of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for the buffer overrun bugfix required for Base64 decoding to work properly.
Depends on PR 860, 861, and 862.
Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported.
Testing: x86_64 build, affected tests, tier1
Thanks,
--Scott
Progress
Integration blocker
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/863/head:pull/863$ git checkout pull/863Update a local copy of the PR:
$ git checkout pull/863$ git pull https://git.openjdk.org/jdk17u-dev pull/863/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 863View PR using the GUI difftool:
$ git pr show -t 863Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/863.diff