Skip to content

Conversation

@asgibbons
Copy link
Contributor

@asgibbons asgibbons commented Nov 8, 2022

Second of 3 dependent backports for Base64 that are required to get the real bugfix cleanly integrated. The next one will be for the buffer overrun bugfix required for Base64 decoding to work properly.

Depends on PR 860, 861, and 862.

Risk: I view the risk of this backport to be minimal. This code has been in use for many months with no bugs reported.

Testing: x86_64 build, affected tests, tier1

Thanks,
--Scott


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #862 must be integrated first

Issue

  • JDK-8274527: Minimal VM build fails after JDK-8273459

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/863/head:pull/863
$ git checkout pull/863

Update a local copy of the PR:
$ git checkout pull/863
$ git pull https://git.openjdk.org/jdk17u-dev pull/863/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 863

View PR using the GUI difftool:
$ git pr show -t 863

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/863.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2022

👋 Welcome back asgibbons! A progress list of the required criteria for merging this PR into pr/862 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 8, 2022

⚠️ @asgibbons could not find any commit with hash cdd8743b217f9d6a2f814fe27ebfc544e343055e. Please update the title with the hash for an existing commit.

@asgibbons asgibbons changed the title Backport cdd8743b217f9d6a2f814fe27ebfc544e343055e Backport a8edd1b360d4e5f35aff371a91fda42eeb00d395 Nov 8, 2022
@openjdk openjdk bot changed the title Backport a8edd1b360d4e5f35aff371a91fda42eeb00d395 8274527: Minimal VM build fails after JDK-8273459 Nov 8, 2022
@openjdk
Copy link

openjdk bot commented Nov 8, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review labels Nov 8, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2022

Webrevs

@asgibbons
Copy link
Contributor Author

/integrate
Thanks, Goetz.

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@asgibbons This pull request has not yet been marked as ready for integration.

@dwhite-intel
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@dwhite-intel The change author (@asgibbons) must issue an integrate command before the integration can be sponsored.

@asgibbons
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 9, 2022

@asgibbons This pull request has not yet been marked as ready for integration.

@asgibbons
Copy link
Contributor Author

Opened a clean PR #869

@asgibbons
Copy link
Contributor Author

Closing this because of dependent PR issues. See #861 for details.

@asgibbons asgibbons closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

2 participants