Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294307: ISO 4217 Amendment 173 Update #879

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 11, 2022

A needed update.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/879/head:pull/879
$ git checkout pull/879

Update a local copy of the PR:
$ git checkout pull/879
$ git pull https://git.openjdk.org/jdk17u-dev pull/879/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 879

View PR using the GUI difftool:
$ git pr show -t 879

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/879.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 11, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4b60ed4d08d6e4cfb26bde2533b6f06b8bf3fa25 8294307: ISO 4217 Amendment 173 Update Nov 11, 2022
@openjdk
Copy link

openjdk bot commented Nov 11, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 11, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294307: ISO 4217 Amendment 173 Update

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 11, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 11, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Nov 15, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 15, 2022

Going to push as commit cfedd3f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 175bd05: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment
  • 3486bb2: 8295872: [PPC64] JfrGetCallTrace: Need pc == nullptr check before frame constructor

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 15, 2022
@openjdk openjdk bot closed this Nov 15, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 15, 2022
@openjdk
Copy link

openjdk bot commented Nov 15, 2022

@GoeLin Pushed as commit cfedd3f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant