Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8186670: Implement _onSpinWait() intrinsic for AArch64 #88

Closed
wants to merge 1 commit into from

Conversation

eastig
Copy link
Contributor

@eastig eastig commented Jan 13, 2022

Tested with fastdebug build:

  • make test TEST="gtest": Passed
  • make run-test TEST="tier1": Passed
  • make run-test TEST="tier2": Passed
  • make run-test TEST=hotspot/jtreg/compiler/onSpinWait: Passed

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issues

  • JDK-8186670: Implement _onSpinWait() intrinsic for AArch64
  • JDK-8274564: Add diagnostic VM options to control Thread.onSpinWait intrinsic code for AArch64 (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/88/head:pull/88
$ git checkout pull/88

Update a local copy of the PR:
$ git checkout pull/88
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/88/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 88

View PR using the GUI difftool:
$ git pr show -t 88

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/88.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 13, 2022

👋 Welcome back eastig! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6954b98f8faf29b6c2d13687a7a94e83302bdd85 8186670: Implement _onSpinWait() intrinsic for AArch64 Jan 13, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2022

@eastig This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8186670: Implement _onSpinWait() intrinsic for AArch64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • d3eb0a2: 8279998: PPC64 debug builds fail with "untested: RangeCheckStub: predicate_failed_trap_id"
  • f749fc7: 8280002: jmap -histo may leak stream
  • 2137e83: 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
  • 69d296d: 8279833: Loop optimization issue in String.encodeUTF8_UTF16
  • 6f644e0: 8273277: C2: Move conditional negation into rc_predicate
  • d1d0b08: 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it
  • 3354244: 8271202: C1: assert(false) failed: live_in set of first block must be empty
  • e965881: 8263567: gtests don't terminate the VM safely
  • e92b2bc: 8269206: A small typo in comment in test/lib/sun/hotspot/WhiteBox.java
  • 84457e5: 8278309: [windows] use of uninitialized OSThread::_state
  • ... and 10 more: https://git.openjdk.java.net/jdk17u-dev/compare/8d7a6e5d4bc2bd3ad1078202a7f75e1f05e4a78c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Jan 13, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 13, 2022

Webrevs

@eastig
Copy link
Contributor Author

@eastig eastig commented Jan 18, 2022

/integrate

@openjdk openjdk bot added the sponsor label Jan 18, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2022

@eastig
Your change (at version 2bc30be) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

@phohensee phohensee commented Jan 18, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2022

@phohensee Only the author (@eastig) is allowed to issue the integrate command. As this pull request is ready to be sponsored, and you are an eligible sponsor, did you mean to issue the /sponsor command?

@phohensee
Copy link
Member

@phohensee phohensee commented Jan 18, 2022

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2022

Going to push as commit c7329f3.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 761e298: 8276766: Enable jar and jmod to produce deterministic timestamped content
  • d3eb0a2: 8279998: PPC64 debug builds fail with "untested: RangeCheckStub: predicate_failed_trap_id"
  • f749fc7: 8280002: jmap -histo may leak stream
  • 2137e83: 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
  • 69d296d: 8279833: Loop optimization issue in String.encodeUTF8_UTF16
  • 6f644e0: 8273277: C2: Move conditional negation into rc_predicate
  • d1d0b08: 8279412: [JVMCI] failed speculations list must outlive any nmethod that refers to it
  • 3354244: 8271202: C1: assert(false) failed: live_in set of first block must be empty
  • e965881: 8263567: gtests don't terminate the VM safely
  • e92b2bc: 8269206: A small typo in comment in test/lib/sun/hotspot/WhiteBox.java
  • ... and 11 more: https://git.openjdk.java.net/jdk17u-dev/compare/8d7a6e5d4bc2bd3ad1078202a7f75e1f05e4a78c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 18, 2022
@openjdk openjdk bot closed this Jan 18, 2022
@openjdk openjdk bot removed ready rfr sponsor labels Jan 18, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2022

@phohensee @eastig Pushed as commit c7329f3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants