8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled

[wkia]

Backport JDK-8065422 to 17u

Clean backport, GHA passed.

Please note that new test added by the change fails for now because of the certs are expired in March, 2022. To fix this, there are additional JDK fixes being backported as dependant PRs:

• 8282398: EndingDotHostname.java test fails because SSL cert expired #881
• 8282511: Use fixed certificate validation date in SSLExampleCert template #882

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/880/head:pull/880
$ git checkout pull/880

Update a local copy of the PR:
$ git checkout pull/880
$ git pull https://git.openjdk.org/jdk17u-dev pull/880/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 880

View PR using the GUI difftool:
$ git pr show -t 880

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/880.diff

[bridgekeeper]

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 10b7a6d: 8289524: Add JFR JIT restart event
• 8ce7bb4: 8029633: Raw inner class constructor ref should not perform diamond inference
• cfedd3f: 8294307: ISO 4217 Amendment 173 Update
• 175bd05: 8285794: AsyncGetCallTrace might acquire a lock via JavaThread::thread_from_jni_environment

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[mlbridge]

Webrevs

• 00: Full (f56515fc)

[wkia]

/integrate

[openjdk]

@wkia
Your change (at version f56515f) is now ready to be sponsored by a Committer.

[yan-too]

/sponsor

[openjdk]

Going to push as commit a596d64.
Since your change was applied there have been 28 commits pushed to the master branch:

• 4f5326c: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
• 2f7e673: 8289301: P11Cipher should not throw out of bounds exception during padding
• 4a9774a: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
• 842edfe: 8274903: Zero: Support AsyncGetCallTrace
• 174c147: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
• c260e8a: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
• 14eb228: 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines
• 24ac347: 8266519: Cleanup resolve() leftovers from BarrierSet et al
• 5125320: 8283999: Update JMH devkit to 1.35
• 5c80285: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
• ... and 18 more: https://git.openjdk.org/jdk17u-dev/compare/3486bb2f8f89c6266e67b6efbc68dac14b2e6e74...master

Your commit was automatically rebased without conflicts.

[openjdk]

@yan-too @wkia Pushed as commit a596d64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.