Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274903: Zero: Support AsyncGetCallTrace #885

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 16, 2022

Clean backport to improve Zero maintenance.

Additional testing:

  • Linux x86_64 Zero, eyeballing JMH -prof async results
  • Linux x86_64 Zero fastdebug make bootcycle-images

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/885/head:pull/885
$ git checkout pull/885

Update a local copy of the PR:
$ git checkout pull/885
$ git pull https://git.openjdk.org/jdk17u-dev pull/885/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 885

View PR using the GUI difftool:
$ git pr show -t 885

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/885.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 92aa75b72185c681757e6520d6fdc1ae4161d0c5 8274903: Zero: Support AsyncGetCallTrace Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274903: Zero: Support AsyncGetCallTrace

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 5c80285: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • 1bbe4c2: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
  • d0ad871: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout
  • 94b9081: 8296632: Write a test to verify the content change of TextArea sends TextEvent
  • 023f651: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out
  • 8f4a3a5: 8273880: Zero: Print warnings when unsupported intrinsics are enabled
  • 3f79952: 8278826: Print error if Shenandoah flags are empty (instead of crashing)
  • 112ea1d: 8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size
  • a167975: 8280391: NMT: Correct NMT tag on CollectedHeap
  • 7a111ea: 8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier()
  • ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/8ce7bb4ed8903384a85b348cfbe5a89b961ba53b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2022

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

Going to push as commit 842edfe.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 174c147: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
  • c260e8a: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
  • 14eb228: 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines
  • 24ac347: 8266519: Cleanup resolve() leftovers from BarrierSet et al
  • 5125320: 8283999: Update JMH devkit to 1.35
  • 5c80285: 8286624: Regression Test CoordinateTruncationBug.java fails on OL8.3
  • 1bbe4c2: 8285604: closed sun/java2d/GdiRendering/ClipShapeRendering.java failed with "Incorrect color ffeeeeee instead of ff0000ff in pixel (100, 100)"
  • d0ad871: 8178698: javax/sound/midi/Sequencer/MetaCallback.java failed with timeout
  • 94b9081: 8296632: Write a test to verify the content change of TextArea sends TextEvent
  • 023f651: 8279536: jdk/nio/zipfs/ZipFSOutputStreamTest.java timed out
  • ... and 11 more: https://git.openjdk.org/jdk17u-dev/compare/8ce7bb4ed8903384a85b348cfbe5a89b961ba53b...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 22, 2022
@openjdk openjdk bot closed this Nov 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@shipilev Pushed as commit 842edfe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8274903-zero-agct branch January 4, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant