Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280784: VM_Cleanup unnecessarily processes all thread oops #889

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 16, 2022

Clean backport of performance enhancement for GCs that do concurrent thread roots (in JDK 17u those are Shenandoah and Z). On my machine, with Shenandoah running 20K threads, the safepoint cleanup time for "Cleanup" VM ops dropped from 2ms to nearly zero. A possible follow-up would be JDK-8280817, which would extend this to other "empty" ops.

Additional testing:

  • Ad-hoc benchmarks
  • Linux x86_64 fastdebug tier1, tier2
  • Linux x86_64 fastdebug tier1, tier2 with -XX:+DeoptimizeALot
  • Linux x86_64 fastdebug tier1, tier2 with -XX:+UseShenandoahGC

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280784: VM_Cleanup unnecessarily processes all thread oops

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/889/head:pull/889
$ git checkout pull/889

Update a local copy of the PR:
$ git checkout pull/889
$ git pull https://git.openjdk.org/jdk17u-dev pull/889/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 889

View PR using the GUI difftool:
$ git pr show -t 889

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/889.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8a3cca09ba427282f2712bec7298b85bbacf076b 8280784: VM_Cleanup unnecessarily processes all thread oops Nov 16, 2022
@openjdk
Copy link

openjdk bot commented Nov 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 16, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280784: VM_Cleanup unnecessarily processes all thread oops

Reviewed-by: stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 16, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2022

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev
Copy link
Member Author

shipilev commented Jan 3, 2023

@stefank, would you like to ack this?

@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 10, 2023

Going to push as commit fea3818.
Since your change was applied there has been 1 commit pushed to the master branch:

  • f2c3f35: 8297088: Update LCMS to 2.14

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 10, 2023
@openjdk openjdk bot closed this Jan 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 10, 2023
@openjdk
Copy link

openjdk bot commented Jan 10, 2023

@shipilev Pushed as commit fea3818.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants