Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size #892

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 17, 2022

Clean backport to improve test reliability.

Additional testing

  • Linux x86_64 fastdebug, gc/epsilon

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/892/head:pull/892
$ git checkout pull/892

Update a local copy of the PR:
$ git checkout pull/892
$ git pull https://git.openjdk.org/jdk17u-dev pull/892/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 892

View PR using the GUI difftool:
$ git pr show -t 892

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/892.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 37ff7f3b66eaa74d62d6a93f2f34ec744db21834 8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size Nov 17, 2022
@openjdk
Copy link

openjdk bot commented Nov 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 17, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8277866: gc/epsilon/TestMemoryMXBeans.java failed with wrong initial heap size

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • d4d4dbc: 8295419: JFR: Change name of jdk.JitRestart
  • 10b7a6d: 8289524: Add JFR JIT restart event

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 17, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2022

Webrevs

@shipilev
Copy link
Member Author

Got the push approval.

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

Going to push as commit 112ea1d.
Since your change was applied there have been 8 commits pushed to the master branch:

  • a167975: 8280391: NMT: Correct NMT tag on CollectedHeap
  • 7a111ea: 8290374: Shenandoah: Remove inaccurate comment on SBS::load_reference_barrier()
  • 728dc4d: 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM
  • 1c13d7e: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"
  • 52103da: 8293834: Update CLDR data following tzdata 2022c update
  • 32aec43: 8284533: Improve InterpreterCodelet data footprint
  • d4d4dbc: 8295419: JFR: Change name of jdk.JitRestart
  • 10b7a6d: 8289524: Add JFR JIT restart event

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2022
@openjdk openjdk bot closed this Nov 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@shipilev Pushed as commit 112ea1d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8277866-epsilon-test branch January 4, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant