Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM #897

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 18, 2022

Backport for JDK-8296083 javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

Original commit openjdk/jdk@dd9aa72

Clean backport.
Test update, low risk.
Test passed during manual run (run in a 50 loop).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/897/head:pull/897
$ git checkout pull/897

Update a local copy of the PR:
$ git checkout pull/897
$ git pull https://git.openjdk.org/jdk17u-dev pull/897/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 897

View PR using the GUI difftool:
$ git pr show -t 897

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/897.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dd9aa7272d04b49dd5cbf3ff9f9091c7d63d68ae 8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

You may mark changes that only needed a resolve in the ProblemList as /clean.

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296083: javax/swing/JTree/6263446/bug6263446.java fails intermittently on a VM

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 1c13d7e: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 18, 2022
@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@Rudometov
Your change (at version 28d379e) is now ready to be sponsored by a Committer.

@Rudometov
Copy link
Member Author

Thank you. Unfortunately I do not have enough privileges to use /clean, I've tried it some time ago on a different backport.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

Going to push as commit 728dc4d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 1c13d7e: 8290839: jdk/jfr/event/compiler/TestJitRestart.java failed with "RuntimeException: No JIT restart event found: expected true, was false"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 18, 2022
@openjdk openjdk bot closed this Nov 18, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@phohensee @Rudometov Pushed as commit 728dc4d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 8296083 branch January 20, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
4 participants