New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails #898
Conversation
👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@Rudometov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
Linux x86 failure in jtreg:test/hotspot/jtreg:tier1_gc, the test/hotspot/jtreg/gc/stringdedup/TestStringDeduplicationTools.java in particular is not related to the test update in this pr |
/integrate |
@Rudometov |
There are related open testbugs for this test, for example https://bugs.openjdk.org/browse/JDK-8297153 -- how does this affect 17u test stability? Should we wait for this test to be stabilized? |
Good point, totally agree to wait for this test to stabilize. Thank you. |
/sponsor |
Going to push as commit 4a9774a.
Your commit was automatically rebased without conflicts. |
@phohensee @Rudometov Pushed as commit 4a9774a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport for JDK-8022403 sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
Cherry-picked from openjdk/jdk@65f7de2
Clean test backport, had to merge ProblemList.txt.
Test update, low risk.
Test passed during manual run using cmd:
make run-test TEST=test/jdk/sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/898/head:pull/898
$ git checkout pull/898
Update a local copy of the PR:
$ git checkout pull/898
$ git pull https://git.openjdk.org/jdk17u-dev pull/898/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 898
View PR using the GUI difftool:
$ git pr show -t 898
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/898.diff