Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests #900

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 18, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/900/head:pull/900
$ git checkout pull/900

Update a local copy of the PR:
$ git checkout pull/900
$ git pull https://git.openjdk.org/jdk17u-dev pull/900/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 900

View PR using the GUI difftool:
$ git pr show -t 900

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/900.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d5d34241e21305379f1858556f225e7645cd294e 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests Nov 18, 2022
@openjdk
Copy link

openjdk bot commented Nov 18, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 18, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 18, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2022

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 25, 2022

Going to push as commit 44c8733.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 22ad409: 8295952: Problemlist existing compiler/rtm tests also on x86
  • 8ed9f83: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • aec0884: 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool
  • 20f2218: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField
  • 4c87089: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used
  • 22df666: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • 10e1627: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect
  • 615bf95: 8270155: ARM32: Improve register dump in hs_err
  • 1743825: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation
  • 4f5d847: 8282511: Use fixed certificate validation date in SSLExampleCert template
  • ... and 22 more: https://git.openjdk.org/jdk17u-dev/compare/1c13d7ef8548d896a8b65dbf258c778b96cbea21...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 25, 2022
@openjdk openjdk bot closed this Nov 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 25, 2022
@openjdk
Copy link

openjdk bot commented Nov 25, 2022

@MBaesken Pushed as commit 44c8733.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant