8283566: G1: Improve G1BarrierSet::enqueue performance

[shipilev]

Clean (after #905) backport to improve G1 performance.

Additional testing:

• Linux x86_64 fastdebug tier1
• Linux x86_64 fastdebug tier2
• Linux x86_64 fastdebug tier3

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8283566: G1: Improve G1BarrierSet::enqueue performance

Reviewers

• Thomas Schatzl (@tschatzl - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/906/head:pull/906
$ git checkout pull/906

Update a local copy of the PR:
$ git checkout pull/906
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/906/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 906

View PR using the GUI difftool:
$ git pr show -t 906

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/906.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into pr/905 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full - Incremental (e9e49d79)
• 02: Full - Incremental (8538bcba)
• 01: Full - Incremental (02f6685c)
• 00: Full (02f6685c)

[bridgekeeper]

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[shipilev]

/open

[openjdk]

@shipilev This pull request is now open

[bridgekeeper]

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@shipilev This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[shipilev]

/open

[openjdk]

@shipilev This pull request is now open

[openjdk]

@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout JDK-8283566-g1-enqueue-perf
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8283566: G1: Improve G1BarrierSet::enqueue performance

Reviewed-by: tschatzl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

@tschatzl, I assume you are good with this too?

[shipilev]

Testing is green. Push approval is there.

/integrate

[openjdk]

Going to push as commit bf0606a.
Since your change was applied there have been 8 commits pushed to the master branch:

• e6e6bed: 8252990: Intrinsify Unsafe.storeStoreFence
• 24e91c1: 8302594: use-after-free in Node::destruct
• d964229: 8302172: [JVMCI] HotSpotResolvedJavaMethodImpl.canBeInlined must respect ForceInline
• 3e0e4f0: 8301338: Identical branch conditions in CompileBroker::print_heapinfo
• ee63f83: 8296412: Special case infinite loops with unmerged backedges in IdealLoopTree::check_safepts
• 1dee04a: 8278146: G1: Rework VM_G1Concurrent VMOp to clearly identify it as pause
• a000b2d: 8238274: (sctp) JDK-7118373 is not fixed for SctpChannel
• f969f81: 8301998: Update HarfBuzz to 7.0.1

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit bf0606a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.