Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296945: PublicMethodsTest is slow due to dependency verification with debug builds #911

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 21, 2022


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296945: PublicMethodsTest is slow due to dependency verification with debug builds

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/911/head:pull/911
$ git checkout pull/911

Update a local copy of the PR:
$ git checkout pull/911
$ git pull https://git.openjdk.org/jdk17u-dev pull/911/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 911

View PR using the GUI difftool:
$ git pr show -t 911

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/911.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2022

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport bcc6b12b711a9c5007d963123fb38a7e72aaf8e5 8296945: PublicMethodsTest is slow due to dependency verification with debug builds Nov 21, 2022
@openjdk
Copy link

openjdk bot commented Nov 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 21, 2022

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296945: PublicMethodsTest is slow due to dependency verification with debug builds

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2022

Webrevs

@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

Going to push as commit 4f5326c.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 2f7e673: 8289301: P11Cipher should not throw out of bounds exception during padding
  • 4a9774a: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
  • 842edfe: 8274903: Zero: Support AsyncGetCallTrace
  • 174c147: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
  • c260e8a: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
  • 14eb228: 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines
  • 24ac347: 8266519: Cleanup resolve() leftovers from BarrierSet et al
  • 5125320: 8283999: Update JMH devkit to 1.35

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2022
@openjdk openjdk bot closed this Nov 23, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@MBaesken Pushed as commit 4f5326c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant