Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273497: building.md should link to both md and html #914

Closed
wants to merge 1 commit into from

Conversation

benty-amzn
Copy link

@benty-amzn benty-amzn commented Nov 22, 2022

Documentation-only fix.
This patch and JDK-8285093 are needed to make JDK-8293550 clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273497: building.md should link to both md and html

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/914/head:pull/914
$ git checkout pull/914

Update a local copy of the PR:
$ git checkout pull/914
$ git pull https://git.openjdk.org/jdk17u-dev pull/914/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 914

View PR using the GUI difftool:
$ git pr show -t 914

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/914.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2022

👋 Welcome back btaylor! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5bfd043e16fa79a101a1bee38c59d42d4cd69a48 8273497: building.md should link to both md and html Nov 22, 2022
@openjdk
Copy link

openjdk bot commented Nov 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 22, 2022

@benty-amzn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273497: building.md should link to both md and html

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • 9336fb2: 8297590: [TESTBUG] HotSpotResolvedJavaFieldTest does not run
  • ae1b055: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx
  • b464cc2: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod
  • b4a4f6a: 8296958: [JVMCI] add API for retrieving ConstantValue attributes
  • 94859b9: 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value
  • 44c8733: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests
  • 22ad409: 8295952: Problemlist existing compiler/rtm tests also on x86
  • 8ed9f83: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • aec0884: 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool
  • 20f2218: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField
  • ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/5c802851d4c8c36bb5551d8896a0a45b9cb83582...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 22, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2022

Webrevs

@benty-amzn
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 29, 2022
@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@benty-amzn
Your change (at version 8a13fcc) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 29, 2022

Going to push as commit a10bb08.
Since your change was applied there have been 27 commits pushed to the master branch:

  • 9336fb2: 8297590: [TESTBUG] HotSpotResolvedJavaFieldTest does not run
  • ae1b055: 8293535: jdk/javadoc/doclet/testJavaFX/TestJavaFxMode.java fail with jfx
  • b464cc2: 8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod
  • b4a4f6a: 8296958: [JVMCI] add API for retrieving ConstantValue attributes
  • 94859b9: 8296956: [JVMCI] HotSpotResolvedJavaFieldImpl.getIndex returns wrong value
  • 44c8733: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests
  • 22ad409: 8295952: Problemlist existing compiler/rtm tests also on x86
  • 8ed9f83: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
  • aec0884: 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool
  • 20f2218: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField
  • ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/5c802851d4c8c36bb5551d8896a0a45b9cb83582...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 29, 2022
@openjdk openjdk bot closed this Nov 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 29, 2022
@openjdk
Copy link

openjdk bot commented Nov 29, 2022

@phohensee @benty-amzn Pushed as commit a10bb08.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants