New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8008243: Zero: Implement fast bytecodes #924
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
This passes my local testing on recent jdk17u-dev. Push approval is also there. I am integrating. /integrate |
Going to push as commit a395cf7.
Your commit was automatically rebased without conflicts. |
Clean backport to improve Zero performance. The rationale for backport is the same as for mainline. Given that Zero is used to implement the JVM on emerging platforms that are still rather slow themselves, it makes sense to make Zero quantifiably faster. Even 10% improvement means more than 2 hours a day worth of CPU time.
This backport requires a follow-up to fix some platforms:
8277485: Zero: Fix fast{i,f}access_0 bytecodes handling
We still have
RewriteBytecodes
to get the original behavior if more bugs appear.Additional testing:
make bootcycle-images
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/924/head:pull/924
$ git checkout pull/924
Update a local copy of the PR:
$ git checkout pull/924
$ git pull https://git.openjdk.org/jdk17u-dev pull/924/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 924
View PR using the GUI difftool:
$ git pr show -t 924
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/924.diff