Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8008243: Zero: Implement fast bytecodes #924

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Nov 23, 2022

Clean backport to improve Zero performance. The rationale for backport is the same as for mainline. Given that Zero is used to implement the JVM on emerging platforms that are still rather slow themselves, it makes sense to make Zero quantifiably faster. Even 10% improvement means more than 2 hours a day worth of CPU time.

This backport requires a follow-up to fix some platforms:
8277485: Zero: Fix fast{i,f}access_0 bytecodes handling

We still have RewriteBytecodes to get the original behavior if more bugs appear.

Additional testing:

  • Linux x86_64 Zero make bootcycle-images

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/924/head:pull/924
$ git checkout pull/924

Update a local copy of the PR:
$ git checkout pull/924
$ git pull https://git.openjdk.org/jdk17u-dev pull/924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 924

View PR using the GUI difftool:
$ git pr show -t 924

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/924.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2022

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e4362007da8e40c076493364df91cf85960a03e7 8008243: Zero: Implement fast bytecodes Nov 23, 2022
@openjdk
Copy link

openjdk bot commented Nov 23, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 23, 2022

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8008243: Zero: Implement fast bytecodes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 23, 2022

Webrevs

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2022

@shipilev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@shipilev
Copy link
Member Author

shipilev commented Jan 3, 2023

This passes my local testing on recent jdk17u-dev. Push approval is also there. I am integrating.

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

Going to push as commit a395cf7.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 0916032: 8298035: Provide better descriptions for JIT compiler JFR events
  • ef94eb7: 8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder
  • 0ac93eb: 8295066: Folding of loads is broken in C2 after JDK-8242115
  • abfa08f: 8242115: C2 SATB barriers are not safepoint-safe

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2023
@openjdk openjdk bot closed this Jan 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@shipilev Pushed as commit a395cf7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8008243-zero-fast-bytecodes branch January 4, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant