8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter

[shipilev]

Clean backport to improve ARM32 reliability.

Additional testing:

• Linux ARM32 fastdebug make bootcycle-images

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/927/head:pull/927
$ git checkout pull/927

Update a local copy of the PR:
$ git checkout pull/927
$ git pull https://git.openjdk.org/jdk17u-dev pull/927/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 927

View PR using the GUI difftool:
$ git pr show -t 927

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/927.diff

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• 4f5326c: 8296945: PublicMethodsTest is slow due to dependency verification with debug builds
• 2f7e673: 8289301: P11Cipher should not throw out of bounds exception during padding
• 4a9774a: 8022403: sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java fails
• 842edfe: 8274903: Zero: Support AsyncGetCallTrace
• 174c147: 8273380: ARM32: Default to {ldrexd,strexd} in StubRoutines::atomic_{load|store}_long
• c260e8a: 8271834: TestStringDeduplicationAgeThreshold intermittent failures on Shenandoah
• 14eb228: 8280016: gc/g1/TestShrinkAuxiliaryData30 test fails on large machines
• 24ac347: 8266519: Cleanup resolve() leftovers from BarrierSet et al
• 5125320: 8283999: Update JMH devkit to 1.35

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mlbridge]

Webrevs

• 00: Full (f39ddb31)

[shipilev]

@mychris, you might want to take a look or even test this for 17u? Thanks.

[mychris]

Hey Aleksey,

thanks for the backport. Code looks good.
I haven't worked on ARMv5 for a long time, so I have to reactivate my setup and see if I can run some tests.
Will report back as soon as I have some results.

[mychris]

Problem is fixed by the backport.
I ran some of the tier1 tests and all looks good. I can't run the whole suite right now, would take way too long.
👍 from my side.

[shipilev]

Excellent, thanks for testing. We got push approval too, so I am integrating.

/integrate

[openjdk]

Going to push as commit 8ed9f83.
Since your change was applied there have been 19 commits pushed to the master branch:

• aec0884: 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool
• 20f2218: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField
• 4c87089: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used
• 22df666: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
• 10e1627: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect
• 615bf95: 8270155: ARM32: Improve register dump in hs_err
• 1743825: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation
• 4f5d847: 8282511: Use fixed certificate validation date in SSLExampleCert template
• c086725: 8282398: EndingDotHostname.java test fails because SSL cert expired
• a596d64: 8065422: Trailing dot in hostname causes TLS handshake to fail with SNI disabled
• ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/5c802851d4c8c36bb5551d8896a0a45b9cb83582...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 8ed9f83.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.