Skip to content

Conversation

@jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Nov 24, 2022

Clean backport which is needed for JDK 17-based future GraalVM builds.

Testing: jvmci tests (passed).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/929/head:pull/929
$ git checkout pull/929

Update a local copy of the PR:
$ git checkout pull/929
$ git pull https://git.openjdk.org/jdk17u-dev pull/929/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 929

View PR using the GUI difftool:
$ git pr show -t 929

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/929.diff

…dJavaMethod/ResolvedJavaField

Reviewed-by: never
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5db1b58c867608573a9e7cc57ca2ba22c9dd80d4 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 24, 2022
@openjdk
Copy link

openjdk bot commented Nov 24, 2022

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 615bf95: 8270155: ARM32: Improve register dump in hs_err
  • 1743825: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation
  • 4f5d847: 8282511: Use fixed certificate validation date in SSLExampleCert template
  • c086725: 8282398: EndingDotHostname.java test fails because SSL cert expired

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 24, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2022

Webrevs

@jerboaa
Copy link
Contributor Author

jerboaa commented Nov 25, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Nov 25, 2022

Going to push as commit 20f2218.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 4c87089: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used
  • 22df666: 8297241: Update sun/java2d/DirectX/OnScreenRenderingResizeTest/OnScreenRenderingResizeTest.java
  • 10e1627: 8296733: JFR: File Read event for RandomAccessFile::write(byte[]) is incorrect
  • 615bf95: 8270155: ARM32: Improve register dump in hs_err
  • 1743825: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation
  • 4f5d847: 8282511: Use fixed certificate validation date in SSLExampleCert template
  • c086725: 8282398: EndingDotHostname.java test fails because SSL cert expired

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 25, 2022
@openjdk openjdk bot closed this Nov 25, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 25, 2022
@openjdk
Copy link

openjdk bot commented Nov 25, 2022

@jerboaa Pushed as commit 20f2218.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant