8296904: Improve handling of macos xcode toolchain

[RealCLanger]

I had to adapt the configure changes for the new option to the level of code in jdk17u.

Furthermore, I regenerated docs/building.html which brings it in sync with building.md and removes a change that should not have been made when backporting JDK-8280863.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296904: Improve handling of macos xcode toolchain

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/931/head:pull/931
$ git checkout pull/931

Update a local copy of the PR:
$ git checkout pull/931
$ git pull https://git.openjdk.org/jdk17u-dev pull/931/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 931

View PR using the GUI difftool:
$ git pr show -t 931

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/931.diff

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (a385c8fb)

[MBaesken]

We always check TOOLCHAIN_PATH in basic.m4
UTIL_LOOKUP_PROGS(XCODEBUILD, xcodebuild, $TOOLCHAIN_PATH)
Shouldn't we do it similar to jdk/jdk ? There we check in case of DEVKIT_ROOT set, DEKIT_TOOLCHAIN_PATH. In case of TOOLCHAIN_PATH set we check TOOLCHAIN_PATH.

[RealCLanger]

We always check TOOLCHAIN_PATH in basic.m4 UTIL_LOOKUP_PROGS(XCODEBUILD, xcodebuild, $TOOLCHAIN_PATH) Shouldn't we do it similar to jdk/jdk ? There we check in case of DEVKIT_ROOT set, DEKIT_TOOLCHAIN_PATH. In case of TOOLCHAIN_PATH set we check TOOLCHAIN_PATH.

Hm, maybe yes. But in that case we should have a look at backporting JDK-8287254 entirely. For the current level of jdk17u, I would think this fits.

[MBaesken]

Okay thanks for the explanation. Backporting JDK-8287254 is a bit too much for now (maybe later?).

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296904: Improve handling of macos xcode toolchain

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 44c8733: 8295405: Add cause in a couple of IllegalArgumentException and InvalidParameterException shown by sun/security/pkcs11 tests
• 22ad409: 8295952: Problemlist existing compiler/rtm tests also on x86
• 8ed9f83: 8270086: ARM32-softfp: Do not load CONSTANT_double using the condy helper methods in the interpreter
• aec0884: 8296960: [JVMCI] list HotSpotConstantPool.loadReferencedType to ConstantPool
• 20f2218: 8296961: [JVMCI] Access to j.l.r.Method/Constructor/Field for ResolvedJavaMethod/ResolvedJavaField
• 4c87089: 8297147: UnexpectedSourceImageSize test times out on slow machines when fastdebug is used

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 57e6d92.
Since your change was applied there have been 25 commits pushed to the master branch:

• 0f43f8e: 8293965: Code signing warnings after JDK-8293550
• cdaf5e3: 8294310: compare.sh fails on macos after JDK-8293550
• a2fb9ae: 8297211: Expensive fillInStackTrace operation in HttpURLConnection.getOutputStream0 when no content-length in response
• 26b03b5: 8297259: Bump update version for OpenJDK: jdk-17.0.7
• da6fca4: 8293550: Optionally add get-task-allow entitlement to macos binaries
• 85a655b: 8297656: AArch64: Enable AES/GCM Intrinsics
• 8706303: 8297309: Memory leak in ShenandoahFullGC
• d523936: 8297530: java.lang.IllegalArgumentException: Negative length on strings concatenation
• 1f72ba2: 8297481: Create a regression test for JDK-4424517
• 3df0e29: 8296715: CLDR v42 update for tzdata 2022f
• ... and 15 more: https://git.openjdk.org/jdk17u-dev/compare/22df666f116f04e3c3bf6d0a17e845eed5a2c254...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 57e6d92.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.