8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod

[jerboaa]

Not clean. Copyright in HotSpotResolvedJavaMethodImpl.java. getCodeSizeTest in
TestResolvedJavaMethod.java fixed up manually, as well as omitted equalsTest changes
as that test is not in 17u (because both, JDK-8289687 and JDK-8289094 are not in 17u).

HotSpotResolvedJavaFieldTest.java will need a follow-up, JDK-8297590, in order to fix the test
and let it run. I'll get that backported to 17u once it's in JDK tip.

This pr depends on #933 as that PR changes the signature of the createField static method in
HotSpotResolvedObjectTypeImpl (which the test fix of JDK-8297590 corrects).

Testing: jvmci tests (with backport of JDK-8297590 applied). Existing and newly included tests pass.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod

Reviewers

• Andrew Dinn (@adinn - Reviewer) ⚠️ Review applies to 271e5457

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/934/head:pull/934
$ git checkout pull/934

Update a local copy of the PR:
$ git checkout pull/934
$ git pull https://git.openjdk.org/jdk17u-dev pull/934/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 934

View PR using the GUI difftool:
$ git pr show -t 934

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/934.diff

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/933 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (1bc873d5)
• 01: Full - Incremental (271e5457)
• 00: Full (271e5457)

[jerboaa]

@adinn Could you help with a review of this patch too, please? Thank you!

[adinn]

This also looks good.

I agree that dropping equalsTest is correct for this backport. However, if at some point we decide we need to backport JDK-8296967 we will have to try to remember also to reinsert equalsTest.

[jerboaa]

Thanks for the review!

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout jdk-8296967-jdk17u-backport
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296967: [JVMCI] rationalize relationship between getCodeSize and getCode in ResolvedJavaMethod

Reviewed-by: adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk-notifier]

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. All changes will be squashed into a single commit automatically when integrating. See OpenJDK Developers’ Guide for more information.

[jerboaa]

/integrate

[openjdk]

Going to push as commit b464cc2.

[openjdk]

@jerboaa Pushed as commit b464cc2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.