Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297481: Create a regression test for JDK-4424517 #941

Closed
wants to merge 1 commit into from

Conversation

Rudometov
Copy link
Member

@Rudometov Rudometov commented Nov 30, 2022

Backport for JDK-8297481
Create a regression test for JDK-4424517

openjdk/jdk@e2d71c0

Clean backport
New test, low risk.
Test passes during manual run, checked on macos and linux


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8297481: Create a regression test for JDK-4424517

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/941/head:pull/941
$ git checkout pull/941

Update a local copy of the PR:
$ git checkout pull/941
$ git pull https://git.openjdk.org/jdk17u-dev pull/941/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 941

View PR using the GUI difftool:
$ git pr show -t 941

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/941.diff

Reviewed-by: serb
(cherry picked from commit e2d71c0a0d654841e3e591beeaa04b44c6e6b37f)
@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2022

👋 Welcome back vrudomet! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e2d71c0a0d654841e3e591beeaa04b44c6e6b37f 8297481: Create a regression test for JDK-4424517 Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@Rudometov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297481: Create a regression test for JDK-4424517

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2022
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2022

Webrevs

@Rudometov
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 30, 2022
@openjdk
Copy link

openjdk bot commented Nov 30, 2022

@Rudometov
Your change (at version a2cede6) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 1, 2022

Going to push as commit 1f72ba2.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 3df0e29: 8296715: CLDR v42 update for tzdata 2022f
  • 8c0c9b4: 8296957: One more cast in SAFE_SIZE_NEW_ARRAY2
  • d982158: 8296496: Overzealous check in sizecalc.h prevents large memory allocation
  • 5b77b57: 8285093: Introduce UTIL_ARG_WITH

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2022
@openjdk openjdk bot closed this Dec 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 1, 2022
@openjdk
Copy link

openjdk bot commented Dec 1, 2022

@phohensee @Rudometov Pushed as commit 1f72ba2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Rudometov Rudometov deleted the 8297481 branch January 20, 2023 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants