Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR #947

Closed
wants to merge 2 commits into from

Conversation

veita
Copy link

@veita veita commented Dec 3, 2022

Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/947/head:pull/947
$ git checkout pull/947

Update a local copy of the PR:
$ git checkout pull/947
$ git pull https://git.openjdk.org/jdk17u-dev pull/947/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 947

View PR using the GUI difftool:
$ git pr show -t 947

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/947.diff

Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Dec 3, 2022
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 3, 2022

Hi @veita, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user veita" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@veita
Copy link
Author

veita commented Dec 3, 2022

OCA has been /signed and submitted at 2022-12-02. Still under review.

@veita
Copy link
Author

veita commented Dec 3, 2022

OCA /signed 2022-12-02

@jerboaa
Copy link
Contributor

jerboaa commented Dec 5, 2022

@veita Please change the PR title to Backport a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d. That will help the bots recognize it as a backport and will subsequently change the PR title back to the original bug synopsis. It also seems the tests are missing.

@veita veita changed the title 8297684: NullPointerException in JarVerifier prevents JVM from starting Backport a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d Dec 5, 2022
@openjdk openjdk bot changed the title Backport a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR Dec 5, 2022
@openjdk
Copy link

openjdk bot commented Dec 5, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 5, 2022
@veita
Copy link
Author

veita commented Dec 5, 2022

It also seems the tests are missing.

https://bugs.openjdk.org/browse/JDK-8280890 seems to cover a slightly different issue than https://bugs.openjdk.org/browse/JDK-8297684. I don't know if the changes in keytool are applicable for Java 17. So to be as least invasive as possible I've only backported the parts relevant for the latter issue.

Regarding the test, I could copy the files that were added in 19 to the PR. However, I don't know if they actually test keytool or the algorithm constraints, or both.

One last question: Does there exist documentation about how to configure an IDE (preferably Eclipse) to compile the JDK. Currently I don't have a workspace that compiles test/jdk without errors. So making changes there is kind of blind flying.

Backport-of: a0f6f2409ea61ff9ed9dc2e2b46e309c751d456d
@veita
Copy link
Author

veita commented Dec 6, 2022

It also seems the tests are missing.

Backported the full patch for JDK-8280890 (including tests).

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Dec 23, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 23, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 23, 2022

Webrevs

@jerboaa
Copy link
Contributor

jerboaa commented Dec 23, 2022

@veita Shame this took so long. But this has been fixed with: openjdk/jdk17u@0ab310e (should be in 17.0.6) in January. Feel free to verify with a nightly build once available.

This PR should be closed.

@veita
Copy link
Author

veita commented Dec 23, 2022

Great. Thank you!

@veita veita closed this Dec 23, 2022
@veita
Copy link
Author

veita commented Jan 12, 2023

Verified. We could not reproduce the bug with the latest nightly build.

@jerboaa
Copy link
Contributor

jerboaa commented Jan 12, 2023

Thanks for checking!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
2 participants