-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds #957
Conversation
👋 Welcome back sxa! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
@sxa This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 533 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Approved for 17u.
/integrate |
/sponsor |
Going to push as commit d5e0d44.
Your commit was automatically rebased without conflicts. |
@gnu-andrew @sxa Pushed as commit d5e0d44. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is a clean backport of openjdk/jdk#11665 which fixes a compliance issue on AIX.
Relevant issue: https://bugs.openjdk.org/browse/JDK-8298726
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/957/head:pull/957
$ git checkout pull/957
Update a local copy of the PR:
$ git checkout pull/957
$ git pull https://git.openjdk.org/jdk17u-dev pull/957/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 957
View PR using the GUI difftool:
$ git pr show -t 957
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/957.diff