Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds #957

Closed
wants to merge 1 commit into from

Conversation

sxa
Copy link
Contributor

@sxa sxa commented Dec 20, 2022

This is a clean backport of openjdk/jdk#11665 which fixes a compliance issue on AIX.
Relevant issue: https://bugs.openjdk.org/browse/JDK-8298726


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/957/head:pull/957
$ git checkout pull/957

Update a local copy of the PR:
$ git checkout pull/957
$ git pull https://git.openjdk.org/jdk17u-dev pull/957/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 957

View PR using the GUI difftool:
$ git pr show -t 957

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/957.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

👋 Welcome back sxa! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@sxa sxa changed the title Backport 5f63f7a JDK-8298726: Backport 5f63f7a Dec 20, 2022
@sxa sxa changed the title JDK-8298726: Backport 5f63f7a JDK-8298726: Backport 5f63f7a (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds Dec 20, 2022
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 20, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2022

Webrevs

@sxa sxa changed the title JDK-8298726: Backport 5f63f7a (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds JDK-8298726: Backport 5f63f7a Dec 20, 2022
@sxa sxa changed the title JDK-8298726: Backport 5f63f7a Backport 5f63f7a742a1071a87ca69463bae6e04a44fe462 Dec 20, 2022
@openjdk openjdk bot changed the title Backport 5f63f7a742a1071a87ca69463bae6e04a44fe462 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

⚠️ @sxa the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout aix_pollingwatch_backport
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@sxa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds

Reviewed-by: andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 533 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@gnu-andrew) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 20, 2022
Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved for 17u.

@sxa
Copy link
Contributor Author

sxa commented Dec 21, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 21, 2022
@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@sxa
Your change (at version 344d1e1) is now ready to be sponsored by a Committer.

@gnu-andrew
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 21, 2022

Going to push as commit d5e0d44.
Since your change was applied there have been 534 commits pushed to the master branch:

  • a11f38a: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved
  • c9d12d4: Merge
  • 12f32df: 8297804: (tz) Update Timezone Data to 2022g
  • 4634a65: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de
  • 27b75a8: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets.
  • 31a18b5: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86
  • 9fdaa33: 8294580: frame::interpreter_frame_print_on() crashes if free BasicObjectLock exists in frame
  • 399a52d: 8298459: Fix msys2 linking and handling out of tree build directory for source zip creation
  • 60a7cdd: Merge
  • d2fdea7: 8293965: Code signing warnings after JDK-8293550
  • ... and 524 more: https://git.openjdk.org/jdk17u-dev/compare/1fece4179035e24a1ff81b9697e53ef612cecfea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 21, 2022
@openjdk openjdk bot closed this Dec 21, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 21, 2022
@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@gnu-andrew @sxa Pushed as commit d5e0d44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants