Skip to content

8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body#958

Closed
RealCLanger wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:RealCLanger-backport-909d0cb4
Closed

8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body#958
RealCLanger wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:RealCLanger-backport-909d0cb4

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Dec 20, 2022

Hi all,

This pull request contains a backport of JDK-8298588, commit 909d0cb4 from the openjdk/jdk repository.

The commit being backported was authored by Michal Karm Babacek on 16 Dec 2022 and was reviewed by Daniel Fuchs.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/958/head:pull/958
$ git checkout pull/958

Update a local copy of the PR:
$ git checkout pull/958
$ git pull https://git.openjdk.org/jdk17u-dev pull/958/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 958

View PR using the GUI difftool:
$ git pr show -t 958

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/958.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 20, 2022

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 909d0cb4d9475fd367b8bc64a6b50c5a324e9a01 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Dec 20, 2022
@openjdk
Copy link

openjdk bot commented Dec 20, 2022

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 20, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 20, 2022

Webrevs

@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

Going to push as commit d973531.
Since your change was applied there have been 5 commits pushed to the master branch:

  • d5e0d44: 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds
  • a11f38a: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved
  • c9d12d4: Merge
  • 12f32df: 8297804: (tz) Update Timezone Data to 2022g
  • 4634a65: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 22, 2022
@openjdk openjdk bot closed this Dec 22, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@RealCLanger Pushed as commit d973531.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant

Comments