8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body#958
Conversation
|
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit d973531.
Your commit was automatically rebased without conflicts. |
|
@RealCLanger Pushed as commit d973531. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8298588, commit 909d0cb4 from the openjdk/jdk repository.
The commit being backported was authored by Michal Karm Babacek on 16 Dec 2022 and was reviewed by Daniel Fuchs.
Thanks!
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/958/head:pull/958$ git checkout pull/958Update a local copy of the PR:
$ git checkout pull/958$ git pull https://git.openjdk.org/jdk17u-dev pull/958/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 958View PR using the GUI difftool:
$ git pr show -t 958Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/958.diff