Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out #962

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 21, 2022

I backport this for parity with 17.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/962/head:pull/962
$ git checkout pull/962

Update a local copy of the PR:
$ git checkout pull/962
$ git pull https://git.openjdk.org/jdk17u-dev pull/962/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 962

View PR using the GUI difftool:
$ git pr show -t 962

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/962.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 46684a4efa165d97c0ef8f56248ee82003acdb7b 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out Dec 21, 2022
@openjdk
Copy link

openjdk bot commented Dec 21, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 21, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 21, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 27, 2022

Going to push as commit 5194b98.
Since your change was applied there have been 8 commits pushed to the master branch:

  • e6d369c: 8271471: [IR Framework] Rare occurrence of "" in PrintIdeal/PrintOptoAssembly can let tests fail
  • 3ff9669: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes
  • e0368a2: 8283606: Tests may fail with zh locale on MacOS
  • e262f64: 8288005: HotSpot build with disabled PCH fails for Windows AArch64
  • 1da982b: 8298527: Cygwin's uname -m returns different string than before
  • d973531: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body
  • d5e0d44: 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds
  • a11f38a: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 27, 2022
@openjdk openjdk bot closed this Dec 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 27, 2022
@openjdk
Copy link

openjdk bot commented Dec 27, 2022

@GoeLin Pushed as commit 5194b98.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant