Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8244669: convert clhsdb "mem" command from javascript to java #968

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 22, 2022

I backport this for parity with 17.0.7-oracle.
Did not apply clean because in head dead variable
String format = "";
was removed in CommandProcessor (8277413).
I removed that too.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8244669: convert clhsdb "mem" command from javascript to java

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/968/head:pull/968
$ git checkout pull/968

Update a local copy of the PR:
$ git checkout pull/968
$ git pull https://git.openjdk.org/jdk17u-dev pull/968/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 968

View PR using the GUI difftool:
$ git pr show -t 968

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/968.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport eaefb1a1ed9edea440628e3a5c5483ebd52bfcb0 8244669: convert clhsdb "mem" command from javascript to java Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 22, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2022

Webrevs

Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8244669: convert clhsdb "mem" command from javascript to java

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e262f64: 8288005: HotSpot build with disabled PCH fails for Windows AArch64
  • 1da982b: 8298527: Cygwin's uname -m returns different string than before

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 22, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Dec 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 27, 2022

Going to push as commit 554f17b.
Since your change was applied there have been 7 commits pushed to the master branch:

  • c8caf68: 8279024: Remove javascript references from clhsdb.html
  • 5194b98: 8262386: resourcehogs/serviceability/sa/TestHeapDumpForLargeArray.java timed out
  • e6d369c: 8271471: [IR Framework] Rare occurrence of "" in PrintIdeal/PrintOptoAssembly can let tests fail
  • 3ff9669: 8299015: Ensure that HttpResponse.BodySubscribers.ofFile writes all bytes
  • e0368a2: 8283606: Tests may fail with zh locale on MacOS
  • e262f64: 8288005: HotSpot build with disabled PCH fails for Windows AArch64
  • 1da982b: 8298527: Cygwin's uname -m returns different string than before

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 27, 2022
@openjdk openjdk bot closed this Dec 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 27, 2022
@openjdk
Copy link

openjdk bot commented Dec 27, 2022

@GoeLin Pushed as commit 554f17b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8244669 branch December 27, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants