Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling #975

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 22, 2022

I backport this for parity with 17.0.7-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/975/head:pull/975
$ git checkout pull/975

Update a local copy of the PR:
$ git checkout pull/975
$ git pull https://git.openjdk.org/jdk17u-dev pull/975/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 975

View PR using the GUI difftool:
$ git pr show -t 975

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/975.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport caae53f4dadd146426a1a2cd121ac00bb98ebc97 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2022

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Dec 27, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 27, 2022

Going to push as commit eb95804.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 8b0c5b9: 8292660: C2: blocks made unreachable by NeverBranch-to-Goto conversion are removed incorrectly
  • 9729dad: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly
  • ade0edf: 8292285: C2: remove unreachable block after NeverBranch-to-Goto conversion
  • 6262937: 8155246: Throw error if default java.security file is missing
  • e770114: 8288130: compiler error with AP and explicit record accessor
  • d72709f: 8285399: JNI exception pending in awt_GraphicsEnv.c:1432
  • d8cc8a8: 8282577: ICC_Profile.setData(int, byte[]) invalidates the profile
  • ddaa77b: 8279119: src/jdk.hotspot.agent/doc/index.html file contains references to scripts that no longer exist
  • 9804538: 8274911: testlibrary_tests/ir_framework/tests/TestIRMatching.java fails with "java.lang.RuntimeException: Should have thrown exception"
  • 554f17b: 8244669: convert clhsdb "mem" command from javascript to java
  • ... and 5 more: https://git.openjdk.org/jdk17u-dev/compare/e262f644706c4dce5e5ef4c8d9dda3e8e9f6fffe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 27, 2022
@openjdk openjdk bot closed this Dec 27, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 27, 2022
@openjdk
Copy link

openjdk bot commented Dec 27, 2022

@GoeLin Pushed as commit eb95804.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant