Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298108: Add a regression test for JDK-8297684 #977

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Dec 22, 2022

Clean backport. Adds another reg-test for the issue fixed with openjdk/jdk17u#363


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/977/head:pull/977
$ git checkout pull/977

Update a local copy of the PR:
$ git checkout pull/977
$ git pull https://git.openjdk.org/jdk17u-dev pull/977/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 977

View PR using the GUI difftool:
$ git pr show -t 977

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/977.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 22, 2022

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4da8411674b7515310000bd8243860bc73f9a03d 8298108: Add a regression test for JDK-8297684 Dec 22, 2022
@openjdk
Copy link

openjdk bot commented Dec 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 22, 2022

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298108: Add a regression test for JDK-8297684

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • e262f64: 8288005: HotSpot build with disabled PCH fails for Windows AArch64
  • 1da982b: 8298527: Cygwin's uname -m returns different string than before
  • d973531: 8298588: WebSockets: HandshakeUrlEncodingTest unnecessarily depends on a response body
  • d5e0d44: 8298726: (fs) Change PollingWatchService to record last modified time as FileTime rather than milliseconds
  • a11f38a: 8296611: Problemlist several sun/security tests until JDK-8295343 is resolved
  • c9d12d4: Merge
  • 12f32df: 8297804: (tz) Update Timezone Data to 2022g
  • 4634a65: 8283870: jdeprscan --help causes an exception when the locale is ja, zh_CN or de
  • 27b75a8: 8290322: Optimize Vector.rearrange over byte vectors for AVX512BW targets.
  • 31a18b5: 8290899: java/lang/String/StringRepeat.java test requests too much heap on windows x86
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/399a52dccb2a53a4309fdff479a14d944829cd54...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 22, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 22, 2022

Webrevs

@GoeLin
Copy link
Member

GoeLin commented Dec 23, 2022

Hi @jerboaa,
why are the pre-submit tests red?

@jerboaa
Copy link
Contributor Author

jerboaa commented Dec 23, 2022

Hi @jerboaa, why are the pre-submit tests red?

Seems unrelated both fail with this when trying to download the boot jdk:

HTTP request sent, awaiting response... 503 Egress is over the account limit.

Not sure what's up. Probably running against a limit somewhere.

@jerboaa
Copy link
Contributor Author

jerboaa commented Jan 9, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 9, 2023

Going to push as commit 8a8cdeb.
Since your change was applied there have been 79 commits pushed to the master branch:

  • 1e89246: 8296924: C2: assert(is_valid_AArch64_address(dest.target())) failed: bad address
  • 3e7f840: 8285835: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work
  • 95f23f7: 8292177: InitialSecurityProperty JFR event
  • c95dda4: 8286800: Assert in PhaseIdealLoop::dump_real_LCA is too strong
  • 0ce1205: 8294947: Use 64bit atomics in patch_verified_entry on x86_64
  • 3a019fd: 8294217: Assertion failure: parsing found no loops but there are some
  • c9bbd55: 8292159: TYPE_USE annotations on generic type arguments of record components discarded
  • 013709f: 8294538: missing is_unloading() check in SharedRuntime::fixup_callers_callsite()
  • 6469c30: 8295414: [Aarch64] C2: assert(false) failed: bad AD file
  • 26f0348: 8280868: LineBodyHandlerTest.java creates and discards too many clients
  • ... and 69 more: https://git.openjdk.org/jdk17u-dev/compare/399a52dccb2a53a4309fdff479a14d944829cd54...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 9, 2023
@openjdk openjdk bot closed this Jan 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 9, 2023
@openjdk
Copy link

openjdk bot commented Jan 9, 2023

@jerboaa Pushed as commit 8a8cdeb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants