8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

[jerboaa]

Not clean backport, because the problem list bug JDK-8298274 won't get backported. Omitted the ProblemList.txt hunk. Instead I propose to backport the fix (this PR) instead. Follow up for #977

Please review this test-only backport. Thanks!

Test passes with the fix of openjdk/jdk17u#363 included.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

Reviewers

• Paul Hohensee (@phohensee - Reviewer)
• Christoph Langer (@RealCLanger - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/978/head:pull/978
$ git checkout pull/978

Update a local copy of the PR:
$ git checkout pull/978
$ git pull https://git.openjdk.org/jdk17u-dev pull/978/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 978

View PR using the GUI difftool:
$ git pr show -t 978

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/978.diff

[bridgekeeper]

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into pr/977 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full (b436c16e)
• 01: Full - Incremental (4fc63eed)
• 00: Full (4fc63eed)

[openjdk-notifier]

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout jdk-8298271-backport
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

[jerboaa]

@RealCLanger @GoeLin Could you please help review this trivial fix? Just omits the problem list change from head and fixes a windows test fail seen after #977.

[openjdk]

@jerboaa Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[phohensee]

Lgtm.

[openjdk]

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298271: java/security/SignedJar/spi-calendar-provider/TestSPISigned.java failing on Windows

Reviewed-by: phh, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• 339b93b: 8297431: [JVMCI] HotSpotJVMCIRuntime.encodeThrowable should not throw an exception
• b427938: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378
• ad04159: 8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1
• d784aae: 8276064: CheckCastPP with raw oop input floats below a safepoint
• cf6c041: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
• 6f11502: 8275320: NMT should perform buffer overrun checks

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jerboaa]

Thanks, folks!

[jerboaa]

/integrate

[openjdk]

Going to push as commit c370dec.
Since your change was applied there have been 6 commits pushed to the master branch:

• 339b93b: 8297431: [JVMCI] HotSpotJVMCIRuntime.encodeThrowable should not throw an exception
• b427938: 8297569: URLPermission constructor throws IllegalArgumentException: Invalid characters in hostname after JDK-8294378
• ad04159: 8296912: C2: CreateExNode::Identity fails with assert(i < _max) failed: oob: i=1, _max=1
• d784aae: 8276064: CheckCastPP with raw oop input floats below a safepoint
• cf6c041: 8299439: java/text/Format/NumberFormat/CurrencyFormat.java fails for hr_HR
• 6f11502: 8275320: NMT should perform buffer overrun checks

Your commit was automatically rebased without conflicts.

[openjdk]

@jerboaa Pushed as commit c370dec.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.