Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8298027: Remove SCCS id's from awt jtreg tests #987

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 25, 2022

Hi all,
This pull request contains a backport of commit ba2d28e9 from the openjdk/jdk repository.
The commit being backported was authored by Jayathirth D V on 6 Dec 2022 and was reviewed by Alexey Ivanov.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/987/head:pull/987
$ git checkout pull/987

Update a local copy of the PR:
$ git checkout pull/987
$ git pull https://git.openjdk.org/jdk17u-dev pull/987/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 987

View PR using the GUI difftool:
$ git pr show -t 987

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/987.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 25, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ba2d28e911f4f523334f98fd0186680acafb6f0a 8298027: Remove SCCS id's from awt jtreg tests Dec 25, 2022
@openjdk
Copy link

openjdk bot commented Dec 25, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 25, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8298027: Remove SCCS id's from awt jtreg tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 25, 2022
@mrserb mrserb marked this pull request as ready for review December 25, 2022 05:53
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 25, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 25, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Dec 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 29, 2022

Going to push as commit bcdaebf.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 70f235d: 8293767: AWT test TestSinhalaChar.java has old SCCS markings
  • 11a53b7: Merge
  • 41c9d7d: 8293010: JDI ObjectReference/referringObjects/referringObjects001 fails: assert(env->is_enabled(JVMTI_EVENT_OBJECT_FREE)) failed: checking
  • 0ab310e: 8280890: Cannot use '-Djava.system.class.loader' with class loader in signed JAR
  • 244d194: 8293562: KeepAliveCache Blocks Threads while Closing Connections
  • eb95804: 8289508: Improve test coverage for XPath Axes: ancestor, ancestor-or-self, preceding, and preceding-sibling
  • 8b0c5b9: 8292660: C2: blocks made unreachable by NeverBranch-to-Goto conversion are removed incorrectly
  • 9729dad: 8292877: java/util/concurrent/atomic/Serial.java uses {Double,Long}Accumulator incorrectly
  • ade0edf: 8292285: C2: remove unreachable block after NeverBranch-to-Goto conversion
  • 6262937: 8155246: Throw error if default java.security file is missing
  • ... and 11 more: https://git.openjdk.org/jdk17u-dev/compare/e262f644706c4dce5e5ef4c8d9dda3e8e9f6fffe...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2022
@openjdk openjdk bot closed this Dec 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2022
@openjdk
Copy link

openjdk bot commented Dec 29, 2022

@mrserb Pushed as commit bcdaebf.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant