Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 #989

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 27, 2022

I backport this for parity with 17.0.7-oracle.

Follow up to 8273410.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/989/head:pull/989
$ git checkout pull/989

Update a local copy of the PR:
$ git checkout pull/989
$ git pull https://git.openjdk.org/jdk17u-dev pull/989/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 989

View PR using the GUI difftool:
$ git pr show -t 989

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/989.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 27, 2022

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the base branch from master to pr/988 December 27, 2022 17:22
@GoeLin GoeLin changed the title Goetz backport 8275173 Goetz backport 8275173Backport 451a296510994ff9fe1e0381900ffa9a8a1caa54 Dec 27, 2022
@GoeLin GoeLin changed the title Goetz backport 8275173Backport 451a296510994ff9fe1e0381900ffa9a8a1caa54 Backport 451a296510994ff9fe1e0381900ffa9a8a1caa54 Dec 27, 2022
@openjdk openjdk bot changed the title Backport 451a296510994ff9fe1e0381900ffa9a8a1caa54 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911 Dec 27, 2022
@openjdk
Copy link

openjdk bot commented Dec 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 27, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 27, 2022

Webrevs

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/988 to master December 29, 2022 09:35
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8275173
git fetch https://git.openjdk.org/jdk17u-dev master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Dec 29, 2022
@openjdk openjdk bot added the clean label Dec 29, 2022
@openjdk
Copy link

openjdk bot commented Dec 29, 2022

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • c603f82: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 29, 2022
@GoeLin
Copy link
Member Author

GoeLin commented Dec 29, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Dec 29, 2022

Going to push as commit 219041d.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c603f82: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 29, 2022
@openjdk openjdk bot closed this Dec 29, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 29, 2022
@openjdk
Copy link

openjdk bot commented Dec 29, 2022

@GoeLin Pushed as commit 219041d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8275173 branch December 29, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant