Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8280002: jmap -histo may leak stream #99

Closed

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jan 17, 2022

Clean backport of a small patch that fixes a leak (file handle + memory) introduced with JDK-8215624.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/99/head:pull/99
$ git checkout pull/99

Update a local copy of the PR:
$ git checkout pull/99
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/99/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 99

View PR using the GUI difftool:
$ git pr show -t 99

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/99.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 17, 2022

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c359c358c8ebaf7b1dddbc4b499a7aae65ba6736 8280002: jmap -histo may leak stream Jan 17, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 17, 2022

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8280002: jmap -histo may leak stream

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jan 17, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 17, 2022

Webrevs

@tstuefe
Copy link
Member Author

@tstuefe tstuefe commented Jan 18, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2022

Going to push as commit f749fc7.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 2137e83: 8277069: [REDO] JDK-8276743 Make openjdk build Zip Archive generation "reproducible"
  • 69d296d: 8279833: Loop optimization issue in String.encodeUTF8_UTF16
  • 6f644e0: 8273277: C2: Move conditional negation into rc_predicate

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Jan 18, 2022
@openjdk openjdk bot closed this Jan 18, 2022
@openjdk openjdk bot removed ready rfr labels Jan 18, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Jan 18, 2022

@tstuefe Pushed as commit f749fc7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant