Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275843: Random crashes while the UI code is executed #993

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 29, 2022

Hi all,
This pull request contains a backport of commit a9c1acbb from the openjdk/jdk repository.
The commit being backported was authored by Sergey Bylokhov on 14 Dec 2021 and was reviewed by Alexander Zvegintsev.
Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275843: Random crashes while the UI code is executed

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev pull/993/head:pull/993
$ git checkout pull/993

Update a local copy of the PR:
$ git checkout pull/993
$ git pull https://git.openjdk.org/jdk17u-dev pull/993/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 993

View PR using the GUI difftool:
$ git pr show -t 993

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/993.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 29, 2022

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a9c1acbb8aec46e4a488b7c77bb6318af87747f6 8275843: Random crashes while the UI code is executed Dec 29, 2022
@openjdk
Copy link

openjdk bot commented Dec 29, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 29, 2022

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275843: Random crashes while the UI code is executed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 633a763: 8297959: Provide better descriptions for some Operating System JFR events
  • c0a3bf1: 8297480: GetPrimitiveArrayCritical in imageioJPEG misses result - NULL check
  • cec5a0c: 8288854: getLocalGraphicsEnvironment() on for multi-screen setups throws exception NPE
  • 838ca6a: 8296548: Improve MD5 intrinsic for x86_64
  • 6042c6b: 8295530: Update Zlib Data Compression Library to Version 1.2.13
  • 219041d: 8275173: testlibrary_tests/ir_framework/tests/TestCheckedTests.java fails after JDK-8274911
  • c603f82: 8287217: C2: PhaseCCP: remove not visited nodes, prevent type inconsistency
  • e33c871: 8065097: [macosx] javax/swing/Popup/TaskbarPositionTest.java fails because Popup is one pixel off
  • 032f007: 8273410: IR verification framework fails with "Should find method name in validIrRulesMap"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 29, 2022
@mrserb mrserb marked this pull request as ready for review December 31, 2022 05:27
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 31, 2022
@mlbridge
Copy link

mlbridge bot commented Dec 31, 2022

Webrevs

@mrserb
Copy link
Member Author

mrserb commented Jan 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jan 3, 2023

Going to push as commit 1f4fc33.
Since your change was applied there have been 32 commits pushed to the master branch:

  • 298fef7: 8277485: Zero: Fix fast{i,f}access_0 bytecodes handling
  • a395cf7: 8008243: Zero: Implement fast bytecodes
  • 0916032: 8298035: Provide better descriptions for JIT compiler JFR events
  • ef94eb7: 8280132: Incorrect comparator com.sun.beans.introspect.MethodInfo.MethodOrder
  • 0ac93eb: 8295066: Folding of loads is broken in C2 after JDK-8242115
  • abfa08f: 8242115: C2 SATB barriers are not safepoint-safe
  • 0aa62ae: 8294378: URLPermission constructor exception when using tr locale
  • 6f5fdb3: 8296239: ISO 4217 Amendment 174 Update
  • 9a2743f: 8296136: Use correct register in aarch64_enc_fast_unlock()
  • 7be0b5a: 8293531: C2: some vectorapi tests fail assert "Not monotonic" with flag -XX:TypeProfileLevel=222
  • ... and 22 more: https://git.openjdk.org/jdk17u-dev/compare/bcdaebfa89bb26ba8a136f35142f1fa626b7dd5c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 3, 2023
@openjdk openjdk bot closed this Jan 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 3, 2023
@openjdk
Copy link

openjdk bot commented Jan 3, 2023

@mrserb Pushed as commit 1f4fc33.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant