-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8285497: Add system property for Java SE specification maintenance version #2
8285497: Add system property for Java SE specification maintenance version #2
Conversation
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the |
/csr needed |
@justin-curtis-lu an approved CSR request is already required for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes match those already in 17, 11, and 8 to implement java.specification.maintenance.version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a mostly clean backport of 8285497 with additional copyright header updates and the java.specification.maintenance.version
commented out as needed.
|
/approve yes |
@gnu-andrew |
/integrate |
@justin-curtis-lu Pushed as commit c2c9e7f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR which is a backport of adding the "java.specification.maintenance.version" system property.
The property is initialized with a value of 1, which corresponds with the Java SE 17 Maintenance Release 1.
Note that the only change in this backport is the uncommenting of the system property in
VersionProps.java.template
. And as such, the copyright year is updated to 2024, not the original backport year.For reference, the approved CSR: https://bugs.openjdk.org/browse/JDK-8330418
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-ri.git pull/2/head:pull/2
$ git checkout pull/2
Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.org/jdk17u-ri.git pull/2/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2
View PR using the GUI difftool:
$ git pr show -t 2
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-ri/pull/2.diff
Webrev
Link to Webrev Comment