Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8285497: Add system property for Java SE specification maintenance version #2

Closed

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Apr 18, 2024

Please review this PR which is a backport of adding the "java.specification.maintenance.version" system property.
The property is initialized with a value of 1, which corresponds with the Java SE 17 Maintenance Release 1.

Note that the only change in this backport is the uncommenting of the system property in VersionProps.java.template. And as such, the copyright year is updated to 2024, not the original backport year.

For reference, the approved CSR: https://bugs.openjdk.org/browse/JDK-8330418


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires CSR request JDK-8330418 to be approved
  • JDK-8285497 needs maintainer approval

Issues

  • JDK-8285497: Add system property for Java SE specification maintenance version (Enhancement - P4 - Approved)
  • JDK-8330418: Add system property for Java SE specification maintenance version (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-ri.git pull/2/head:pull/2
$ git checkout pull/2

Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.org/jdk17u-ri.git pull/2/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2

View PR using the GUI difftool:
$ git pr show -t 2

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-ri/pull/2.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2024

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8285497: Add system property for Java SE specification maintenance version

Reviewed-by: lancea, iris, prr, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e9d2641: 8297878: KEM: Implementation
  • af9a602: 8331151: Update .jcheck/conf and version-numbers for 17.0.0.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 59ef76a365eafe40d8d68b4d5e028f0e731abd01 8285497: Add system property for Java SE specification maintenance version Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 18, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2024

Webrevs

@justin-curtis-lu
Copy link
Member Author

/csr needed

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@justin-curtis-lu an approved CSR request is already required for this pull request.

Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes match those already in 17, 11, and 8 to implement java.specification.maintenance.version.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a mostly clean backport of 8285497 with additional copyright header updates and the java.specification.maintenance.version commented out as needed.

@openjdk
Copy link

openjdk bot commented Apr 26, 2024

⚠️ @justin-curtis-lu This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval and removed csr Pull request needs approved CSR before integration labels Apr 26, 2024
@gnu-andrew
Copy link
Member

/approve yes

@openjdk
Copy link

openjdk bot commented May 1, 2024

@gnu-andrew
8285497: The approval request has been approved.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels May 1, 2024
@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 8, 2024

Going to push as commit c2c9e7f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • e9d2641: 8297878: KEM: Implementation
  • af9a602: 8331151: Update .jcheck/conf and version-numbers for 17.0.0.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2024
@openjdk openjdk bot closed this May 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2024
@openjdk
Copy link

openjdk bot commented May 8, 2024

@justin-curtis-lu Pushed as commit c2c9e7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants