Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8307779: Relax the java.awt.Robot specification #3

Closed
wants to merge 2 commits into from

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Apr 18, 2024

Please review the doc only backport PR of openjdk/jdk#13809.

It is clean backport of original commit + build failure fix.

CSR: JDK-8330603


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change requires CSR request JDK-8330603 to be approved
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8307779 needs maintainer approval

Issues

  • JDK-8307779: Relax the java.awt.Robot specification (Bug - P3 - Approved)
  • JDK-8330603: Relax the java.awt.Robot specification (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-ri.git pull/3/head:pull/3
$ git checkout pull/3

Update a local copy of the PR:
$ git checkout pull/3
$ git pull https://git.openjdk.org/jdk17u-ri.git pull/3/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3

View PR using the GUI difftool:
$ git pr show -t 3

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-ri/pull/3.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 18, 2024

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8307779: Relax the java.awt.Robot specification

Reviewed-by: prr, iris, andrew

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e9d2641: 8297878: KEM: Implementation
  • af9a602: 8331151: Update .jcheck/conf and version-numbers for 17.0.0.1

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 21aa057fafd88f4dd677bbf7c99a7eabb6b18409 8307779: Relax the java.awt.Robot specification Apr 18, 2024
@openjdk
Copy link

openjdk bot commented Apr 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Apr 18, 2024
@mlbridge
Copy link

mlbridge bot commented Apr 18, 2024

Webrevs

@azvegint
Copy link
Member Author

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@azvegint an approved CSR request is already required for this pull request.

@azvegint
Copy link
Member Author

azvegint commented Apr 18, 2024

/issue add JDK-8308370

adding fix for the build failure

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@azvegint
Adding additional issue to issue list: 8308370: Fix build failures related to the java.awt.Robot documentation.

@openjdk openjdk bot removed the clean label Apr 18, 2024
@azvegint
Copy link
Member Author

azvegint commented Apr 18, 2024

/issue remove JDK-8308370

JDK-8308370: Fix build failures related to the java.awt.Robot documentation (Bug - P1)

changes included in this fix and the CSR updated accordingly

@openjdk
Copy link

openjdk bot commented Apr 18, 2024

@azvegint
Removing additional issue from issue list: 8308370.

@openjdk openjdk bot added the approval label Apr 25, 2024
Copy link
Member

@irisclark irisclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec changes as expected for 17.0.0.1.

Associated CSR (JDK-8330603) already Approved.

Copy link
Member

@gnu-andrew gnu-andrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified as a clean backport of 8307779 + 8308370
I don't know if it's worth mentioning 8308370 via /issue

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval csr Pull request needs approved CSR before integration labels Apr 25, 2024
@azvegint
Copy link
Member Author

azvegint commented May 8, 2024

/integrate

@openjdk
Copy link

openjdk bot commented May 8, 2024

Going to push as commit fadce2f.
Since your change was applied there have been 3 commits pushed to the master branch:

  • c2c9e7f: 8285497: Add system property for Java SE specification maintenance version
  • e9d2641: 8297878: KEM: Implementation
  • af9a602: 8331151: Update .jcheck/conf and version-numbers for 17.0.0.1

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 8, 2024
@openjdk openjdk bot closed this May 8, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 8, 2024
@openjdk
Copy link

openjdk bot commented May 8, 2024

@azvegint Pushed as commit fadce2f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants