Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263531: Remove unused buffer int #1

Closed
wants to merge 1 commit into from
Closed

8263531: Remove unused buffer int #1

wants to merge 1 commit into from

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Jul 13, 2021

The change for JDK-8257001 left an obsolete int field. Remove it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/1/head:pull/1
$ git checkout pull/1

Update a local copy of the PR:
$ git checkout pull/1
$ git pull https://git.openjdk.java.net/jdk17u pull/1/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1

View PR using the GUI difftool:
$ git pr show -t 1

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/1.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 13, 2021

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ca806ef31970e2d020e631d55b44cfe30e11c5ca 8263531: Remove unused buffer int Jul 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

This backport pull request has now been updated with issue from the original commit.

@kevinrushforth
Copy link
Member

@kevinrushforth kevinrushforth commented Jul 13, 2021

@RealCLanger you need to add a non-empty Description; otherwise this looks good to go.

@openjdk
Copy link

@openjdk openjdk bot commented Jul 13, 2021

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8263531: Remove unused buffer int

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Jul 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 13, 2021

Webrevs

@RealCLanger
Copy link
Contributor Author

@RealCLanger RealCLanger commented Jul 19, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

Going to push as commit 00ffb8f.
Since your change was applied there have been 191 commits pushed to the master branch:

  • d684356: 8262731: [macOS] Exception from "Printable.print" is swallowed during "PrinterJob.print"
  • a32d2ee: 8269276: Additional tests for MessageDigest with different providers
  • 7b4d84c: 8270422: Test build/AbsPathsInImage.java fails after JDK-8259848
  • 72db09b: 8266313: (JEP-356) - RandomGenerator spec implementation requirements tightly coupled to JDK internal classes
  • 3bbd233: 8270075: SplittableRandom extends AbstractSplittableGenerator
  • 381bd62: 8266889: [macosx-aarch64] Crash with SIGBUS in MarkActivationClosure::do_code_blob during vmTestbase/nsk/jvmti/.../bi04t002 test run
  • 82c256e: 8259499: Handling type arguments from outer classes for inner class in javadoc
  • e5db9a9: 8268620: InfiniteLoopException test may fail on x86 platforms
  • 67273ae: 8269865: Async UL needs to handle ERANGE on exceeding SEM_VALUE_MAX
  • 0f54707: 8270056: Generated lambda class can not access protected static method of target class
  • ... and 181 more: https://git.openjdk.java.net/jdk17u/compare/9ad19f7838e6f6e128583c191c5507c1e2bd5083...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 19, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 19, 2021

@RealCLanger Pushed as commit 00ffb8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants