-
Notifications
You must be signed in to change notification settings - Fork 195
8268427: Improve AlgorithmConstraints:checkAlgorithm performance #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back eastig! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@eastig This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
/sponsor |
|
@phohensee @eastig Pushed as commit 456735f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
sun.security.util.AbstractAlgorithmConstraints.checkAlgorithm()uses linear search to check if an algorithm has been disabled. Its execution time is high in the most common case: a checked algorithm is not disabled.This backport replaces the list with an ordered set. This improves AbstractAlgorithmConstraints.checkAlgorithm() performance, especially for permitted algorithms.
The patch applies cleanly. Tier1 and tier2 tests pass with the patch.
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/10/head:pull/10$ git checkout pull/10Update a local copy of the PR:
$ git checkout pull/10$ git pull https://git.openjdk.java.net/jdk17u pull/10/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10View PR using the GUI difftool:
$ git pr show -t 10Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/10.diff