Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8223923: C2: Missing interference with mismatched unsafe accesses #104

Closed
wants to merge 1 commit into from
Closed

8223923: C2: Missing interference with mismatched unsafe accesses #104

wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Sep 28, 2021

Backport of JDK-8223923. Applies cleanly. Approval is pending.

Thanks,
Tobias


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8223923: C2: Missing interference with mismatched unsafe accesses

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u pull/104/head:pull/104
$ git checkout pull/104

Update a local copy of the PR:
$ git checkout pull/104
$ git pull https://git.openjdk.java.net/jdk17u pull/104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 104

View PR using the GUI difftool:
$ git pr show -t 104

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u/pull/104.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 28, 2021

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 86add21a85ec57de00aecb0a18bc99567a91d0d8 8223923: C2: Missing interference with mismatched unsafe accesses Sep 28, 2021
@openjdk
Copy link

openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 28, 2021

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8223923: C2: Missing interference with mismatched unsafe accesses

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Sep 28, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 28, 2021

Webrevs

@TobiHartmann
Copy link
Member Author

TobiHartmann commented Sep 29, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Sep 29, 2021

Going to push as commit 7298db5.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 6141fcc: 8271600: C2: CheckCastPP which should closely follow Allocate is sunk of a loop
  • 5761056: 8270886: Crash in PhaseIdealLoop::verify_strip_mined_scheduling
  • e4bf9f9: 8271340: Crash PhaseIdealLoop::clone_outer_loop
  • 23fa88b: 8272413: Incorrect num of element count calculation for vector cast
  • 2b393f9: 8272574: C2: assert(false) failed: Bad graph detected in build_loop_late
  • da77acb: 8271954: C2: assert(false) failed: Bad graph detected in build_loop_late
  • 056eca0: 8273165: GraphKit::combine_exception_states fails with "matching stack sizes" assert
  • ff3e90f: 8272570: C2: crash in PhaseCFG::global_code_motion
  • 108e1bd: 8271254: javac generates unreachable code when using empty semicolon statement
  • dd70512: 8273408: java.lang.AssertionError: typeSig ERROR on generated class property of record
  • ... and 5 more: https://git.openjdk.java.net/jdk17u/compare/c4dfa5759c5f66953a038ade636d8a1d1013e356...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Sep 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 29, 2021
@openjdk
Copy link

openjdk bot commented Sep 29, 2021

@TobiHartmann Pushed as commit 7298db5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant